mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-31 13:40:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check for Python errors in js tests

Browse Source 
When running a cell in the js tests,
this checks for any errors and treats them as a failure.

Helps avoid confusion caused by silently ignoring failures in Python code.
This commit is contained in:
MinRK 2014-10-06 16:03:13 -07:00
parent e808d23594
commit 845c7b4700
1 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
IPython/html/tests/util.js
View File

@ -204,9 +204,11 @@ casper.append_cell = function(text, cell_type) {
return index;
};
casper.execute_cell = function(index){
casper.execute_cell = function(index, expect_failure){
// Asynchronously executes a cell by index.
// Returns the cell's index.
if (expect_failure === undefined) expect_failure = false;
var that = this;
this.then(function(){
that.evaluate(function (index) {
@ -214,15 +216,37 @@ casper.execute_cell = function(index){
cell.execute();
}, index);
});
this.wait_for_idle();
this.then(function () {
var error = that.evaluate(function (index) {
var cell = IPython.notebook.get_cell(index);
var outputs = cell.output_area.outputs;
for (var i = 0; i < outputs.length; i++) {
if (outputs[i].output_type == 'error') {
return outputs[i];
}
}
return false;
}, index);
if (error === null) {
this.test.fail("Failed to check for error output");
}
if (expect_failure && error === false) {
this.test.fail("Expected error while running cell");
} else if (!expect_failure && error !== false) {
this.test.fail("Error running cell:\n" + error.traceback.join('\n'));
}
});
return index;
};
casper.execute_cell_then = function(index, then_callback) {
casper.execute_cell_then = function(index, then_callback, expect_failure) {
// Synchronously executes a cell by index.
// Optionally accepts a then_callback parameter. then_callback will get called
// when the cell has finished executing.
// Returns the cell's index.
var return_val = this.execute_cell(index);
var return_val = this.execute_cell(index, expect_failure);
this.wait_for_idle();
@ -231,7 +255,7 @@ casper.execute_cell_then = function(index, then_callback) {
if (then_callback!==undefined) {
then_callback.apply(that, [index]);
}
});
});
return return_val;
};