From 7e140c5bafcf83fd51290a4c0865c1512c1345cd Mon Sep 17 00:00:00 2001 From: Matthias Bussonnier Date: Tue, 25 Sep 2018 20:52:21 -0700 Subject: [PATCH] When adapting also log the version jupyter_client is expecting. It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation. --- notebook/services/kernels/handlers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebook/services/kernels/handlers.py b/notebook/services/kernels/handlers.py index 9b751adb9..df079c5c9 100644 --- a/notebook/services/kernels/handlers.py +++ b/notebook/services/kernels/handlers.py @@ -187,7 +187,7 @@ class ZMQChannelsHandler(AuthenticatedZMQStreamHandler): protocol_version = info.get('protocol_version', client_protocol_version) if protocol_version != client_protocol_version: self.session.adapt_version = int(protocol_version.split('.')[0]) - self.log.info("Adapting to protocol v%s for kernel %s", protocol_version, self.kernel_id) + self.log.info("Adapting to protocol v%s for kernel %s (client expecting %s)", protocol_version, self.kernel_id, client_protocol_version) if not self._kernel_info_future.done(): self._kernel_info_future.set_result(info)