mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

When adapting also log the version jupyter_client is expecting.

Browse Source 
It's still (IMHO) unclear how the adaptation goes. Like does "adapting
to protocol X.Y.Z." mean the end-result is X.Y.Z or what you
got is X.Y.Z and it's X.Y.W after adaptation.
This commit is contained in:
Matthias Bussonnier 2018-09-25 20:52:21 -07:00
parent d772277c0b
commit 7e140c5baf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
notebook/services/kernels/handlers.py
View File

@ -187,7 +187,7 @@ class ZMQChannelsHandler(AuthenticatedZMQStreamHandler):
protocol_version = info.get('protocol_version', client_protocol_version)
if protocol_version != client_protocol_version:
self.session.adapt_version = int(protocol_version.split('.')[0])
self.log.info("Adapting to protocol v%s for kernel %s", protocol_version, self.kernel_id)
self.log.info("Adapting to protocol v%s for kernel %s (client expecting %s)", protocol_version, self.kernel_id, client_protocol_version)
if not self._kernel_info_future.done():
self._kernel_info_future.set_result(info)