Do not mutate existing page config

This commit is contained in:
Jeremy Tuloup 2022-04-26 19:43:55 +02:00
parent 722f1d7e6e
commit 72e1464c09

View File

@ -32,19 +32,18 @@ class NotebookBaseHandler(ExtensionHandlerJinjaMixin, ExtensionHandlerMixin, Jup
config = LabConfig() config = LabConfig()
app = self.extensionapp app = self.extensionapp
base_url = self.settings.get("base_url") base_url = self.settings.get("base_url")
page_config = self.settings.setdefault("page_config_data", {}) page_config_data = self.settings.setdefault("page_config_data", {})
page_config.update( page_config = {
{ **page_config_data,
"appVersion": version, "appVersion": version,
"baseUrl": self.base_url, "baseUrl": self.base_url,
"terminalsAvailable": self.settings.get("terminals_available", False), "terminalsAvailable": self.settings.get("terminals_available", False),
"token": self.settings["token"], "token": self.settings["token"],
"fullStaticUrl": ujoin(self.base_url, "static", self.name), "fullStaticUrl": ujoin(self.base_url, "static", self.name),
"frontendUrl": ujoin(self.base_url, "/"), "frontendUrl": ujoin(self.base_url, "/"),
"exposeAppInBrowser": app.expose_app_in_browser, "exposeAppInBrowser": app.expose_app_in_browser,
"collaborative": app.collaborative, "collaborative": app.collaborative,
} }
)
if "hub_prefix" in app.serverapp.tornado_settings: if "hub_prefix" in app.serverapp.tornado_settings:
tornado_settings = app.serverapp.tornado_settings tornado_settings = app.serverapp.tornado_settings