mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-11-21 01:11:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Try resize workaround in tests for now

Browse Source 
Fix order of selectors
This commit is contained in:
Jeremy Tuloup 2022-10-06 10:26:56 +02:00
parent b893cf0d06
commit 708928b2f0
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui-tests/test/mobile.spec.ts
View File

@ -6,9 +6,10 @@ import path from 'path';
import { expect } from '@playwright/test'; import { expect } from '@playwright/test';
import { test } from './fixtures'; import { test } from './fixtures';
import { waitForKernelReady } from './utils'; import { waitForKernelReady } from './utils';
test.use({ autoGoto: false, viewport: { width: 524, height: 800 } }); test.use({ autoGoto: false });
test.describe('Mobile', () => { test.describe('Mobile', () => {
test('The layout should be more compact on the file browser page', async ({ test('The layout should be more compact on the file browser page', async ({
@ -16,7 +17,13 @@ test.describe('Mobile', () => {
tmpPath tmpPath
}) => { }) => {
await page.goto(`tree/${tmpPath}`); await page.goto(`tree/${tmpPath}`);
// temporary workaround to trigger a toolbar resize
// TODO: investigate in https://github.com/jupyter/notebook/issues/6553
await page.setViewportSize({ width: 524, height: 800 });
await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
expect(await page.screenshot()).toMatchSnapshot('tree.png'); expect(await page.screenshot()).toMatchSnapshot('tree.png');
}); });
@ -30,12 +37,14 @@ test.describe('Mobile', () => {
`${tmpPath}/${notebook}` `${tmpPath}/${notebook}`
); );
await page.goto(`notebooks/${tmpPath}/${notebook}`); await page.goto(`notebooks/${tmpPath}/${notebook}`);
// TODO: investigate why this does not run the cells in Jupyter Notebook
// await page.notebook.run();
// wait for the kernel status animations to be finished // wait for the kernel status animations to be finished
await waitForKernelReady(page); await waitForKernelReady(page);
// temporary workaround to trigger a toolbar resize
// TODO: investigate in https://github.com/jupyter/notebook/issues/6553
await page.setViewportSize({ width: 524, height: 800 });
// force switching back to command mode to avoid capturing the cursor in the screenshot // force switching back to command mode to avoid capturing the cursor in the screenshot
await page.evaluate(async () => { await page.evaluate(async () => {
await window.jupyterapp.commands.execute('notebook:enter-command-mode'); await window.jupyterapp.commands.execute('notebook:enter-command-mode');