mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Start webbrowser in a thread. Prevents lockup with Chrome.

Browse Source 
If a user has Chrome set as their default browser (system-wide or via
the `BROWSER` environment variable), opening the notebook hangs
because the chrome call doesn't return immediately.  This solves the
issue by opening the browser in a thread.

Note that there remains an issue where killing the notebook will kill
Chrome if the Chrome session was started by us.  I haven't found a way
to work around that despite attempts by making the webbrowser.open()
call in a subprocess.
This commit is contained in:
Fernando Perez 2011-10-27 17:53:27 -07:00
parent a6c9123018
commit 6e1bbf8fc3
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
IPython/frontend/html/notebook/notebookapp.py
View File

@ -16,14 +16,17 @@ Authors:
# Imports
#-----------------------------------------------------------------------------
# stdlib
import errno
import logging
import os
import signal
import socket
import sys
import threading
import webbrowser
# Third party
import zmq
# Install the pyzmq ioloop. This has to be done before anything else from
@ -35,6 +38,7 @@ tornado.ioloop.IOLoop = ioloop.IOLoop
from tornado import httpserver
from tornado import web
# Our own libraries
from .kernelmanager import MappingKernelManager
from .handlers import (LoginHandler,
ProjectDashboardHandler, NewHandler, NamedNotebookHandler,
@ -301,7 +305,10 @@ class NotebookApp(BaseIPythonApplication):
self.port))
if self.open_browser:
ip = self.ip or '127.0.0.1'
webbrowser.open("%s://%s:%i" % (proto, ip, self.port), new=2)
b = lambda : webbrowser.open("%s://%s:%i" % (proto, ip, self.port),
new=2)
threading.Thread(target=b).start()
ioloop.IOLoop.instance().start()
#-----------------------------------------------------------------------------