mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-31 13:40:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

don't use contains in SelectWidget item_query

Browse Source 
gives false positive matches when some values are substrings of others
This commit is contained in:
MinRK 2014-10-06 12:59:16 -07:00
parent e808d23594
commit 6740d0492e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
IPython/html/static/widgets/js/widget_selection.js
View File

@ -403,7 +403,7 @@ define([
var items = this.model.get('value_names');
var that = this;
_.each(items, function(item, index) {
var item_query = ' :contains("' + item + '")';
var item_query = 'option[value_name="' + item + '"]';
if (that.$listbox.find(item_query).length === 0) {
$('<option />')
.text(item)