mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-18 11:55:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't use animated favicon when kernel busy

Browse Source 
Addresses part of gh-2673

Each set of the favicon causes a new HTTP request.

If we want an animated favicon, I think it's possible to use an animated
GIF. But I find animated favicons annoying, so I'd rather just get rid
of it entirely. Just because we can doesn't mean we should. ;-)
This commit is contained in:
Thomas Kluyver 2017-07-20 14:56:06 +01:00
parent c4a5dc04bf
commit 5c6a1c8f78
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
notebook/static/notebook/js/notificationarea.js
View File

@ -42,21 +42,12 @@ define([
var $modal_ind_icon = $("#modal_indicator");
var $readonly_ind_icon = $('#readonly-indicator');
var $body = $('body');
var interval = 0;
var set_busy_favicon = function(on) {
if (on && !interval) {
var i = 0;
var icons = ['favicon-busy-1.ico', 'favicon-busy-3.ico', 'favicon-busy-3.ico'];
interval = setInterval(function() {
var icon = icons[i % 3];
utils.change_favicon('/static/base/images/' + icon);
i += 1;
}, 300);
if (on) {
utils.change_favicon('/static/base/images/favicon-busy-1.ico');
} else {
clearInterval(interval);
utils.change_favicon('/static/base/images/favicon-notebook.ico');
interval = 0;
}
};