mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-30 12:11:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove redundant js_enabled variable

Browse Source 
it’s only False if the js_testgroups list is empty
This commit is contained in:
MinRK 2014-05-16 15:40:22 -07:00
parent 70c927e97b
commit 5c23ad48d7
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
IPython/testing/iptestcontroller.py
View File

@ -335,15 +335,13 @@ def prepare_controllers(options):
"""Returns two lists of TestController instances, those to run, and those
not to run."""
testgroups = options.testgroups
js_enabled = True
if testgroups:
py_testgroups = [g for g in testgroups if (g in py_test_group_names) \
or g.startswith('IPython.')]
if 'js' in testgroups:
js_testgroups = all_js_groups()
else:
js_testgroups = [g for g in testgroups if g not in py_testgroups]
js_enabled = len(js_testgroups) > 0
js_testgroups = [g for g in testgroups if g.startswith(js_prefix)]
py_testgroups = [g for g in testgroups if g not in ['js'] + js_testgroups]
else:
py_testgroups = py_test_group_names
if not options.all:
@ -352,7 +350,7 @@ def prepare_controllers(options):
else:
js_testgroups = all_js_groups()
c_js = [JSController(name, js_enabled) for name in js_testgroups]
c_js = [JSController(name) for name in js_testgroups]
c_py = [PyTestController(name, options) for name in py_testgroups]
controllers = c_py + c_js