diff --git a/packages/application-extension/src/index.ts b/packages/application-extension/src/index.ts index 466d09535..00011f839 100644 --- a/packages/application-extension/src/index.ts +++ b/packages/application-extension/src/index.ts @@ -197,15 +197,15 @@ const opener: JupyterFrontEndPlugin = { const file = decodeURIComponent(path); const ext = PathExt.extname(file); + + // TODO: fix upstream? + await settingRegistry?.load('@jupyterlab/notebook-extension:panel'); + await new Promise(async () => { // TODO: get factory from file type instead? if (ext === '.ipynb') { - // TODO: fix upstream? - await settingRegistry?.load('@jupyterlab/notebook-extension:panel'); - setTimeout(() => { - docManager.open(file, NOTEBOOK_FACTORY, undefined, { - ref: '_noref' - }); + docManager.open(file, NOTEBOOK_FACTORY, undefined, { + ref: '_noref' }); } else { docManager.open(file, EDITOR_FACTORY, undefined, { diff --git a/ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png b/ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png index d40340ac0..707971159 100644 Binary files a/ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png and b/ui-tests/test/general.spec.ts-snapshots/notebook-firefox-linux.png differ diff --git a/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png b/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png index cfc60f6e5..9cb32711f 100644 Binary files a/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png and b/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png differ diff --git a/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png index 4dd10c34c..3b05e5370 100644 Binary files a/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png and b/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png differ diff --git a/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png index 250266320..6edc57d8c 100644 Binary files a/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png and b/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png differ diff --git a/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png index 0ea79afbb..38244f82e 100644 Binary files a/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png and b/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png differ diff --git a/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png index 017ff95b2..d7e8db695 100644 Binary files a/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png and b/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png differ