mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-18 11:55:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use event.preventDefault() on links creating new files & folders

Browse Source
This commit is contained in:
Thomas Kluyver 2018-01-26 08:49:43 +00:00
parent 1d84d839f3
commit 51acfb61ad
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
notebook/static/tree/js/newnotebook.js
View File

@ -73,7 +73,7 @@ define([
this.events.trigger('kernelspecs_loaded.KernelSpec', data.kernelspecs); this.events.trigger('kernelspecs_loaded.KernelSpec', data.kernelspecs);
}; };
NewNotebookWidget.prototype.new_notebook = function (kernel_name) { NewNotebookWidget.prototype.new_notebook = function (kernel_name, evt) {
/** create and open a new notebook */ /** create and open a new notebook */
var that = this; var that = this;
kernel_name = kernel_name || this.default_kernel; kernel_name = kernel_name || this.default_kernel;
@ -107,6 +107,9 @@ define([
} }
}); });
}); });
if (evt !== undefined) {
evt.preventDefault();
}
}; };
return {'NewNotebookWidget': NewNotebookWidget}; return {'NewNotebookWidget': NewNotebookWidget};

6
notebook/static/tree/js/notebooklist.js
View File

@ -169,6 +169,7 @@ define([
console.warn('Error during New file creation', e); console.warn('Error during New file creation', e);
}); });
that.load_sessions(); that.load_sessions();
e.preventDefault();
}); });
$('#new-folder').click(function(e) { $('#new-folder').click(function(e) {
that.contents.new_untitled(that.notebook_path || '', {type: 'directory'}) that.contents.new_untitled(that.notebook_path || '', {type: 'directory'})
@ -189,6 +190,7 @@ define([
console.warn('Error during New directory creation', e); console.warn('Error during New directory creation', e);
}); });
that.load_sessions(); that.load_sessions();
e.preventDefault();
}); });
// Bind events for action buttons. // Bind events for action buttons.
@ -373,8 +375,8 @@ define([
breadcrumb.append(root); breadcrumb.append(root);
var path_parts = []; var path_parts = [];
this.notebook_path.split('/').forEach(function(path_part) { this.notebook_path.split('/').forEach(function(path_part) {
path_parts.push(path_part) path_parts.push(path_part);
var path = path_parts.join('/') var path = path_parts.join('/');
var url = utils.url_path_join( var url = utils.url_path_join(
that.base_url, that.base_url,
'/tree', '/tree',