mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Feedback: improve test coverage.

Browse Source
This commit is contained in:
Kris Wilson 2020-04-29 00:06:55 -07:00
parent 8d9b8c6f06
commit 3e28cfd603
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
notebook/tests/test_notebookapp_integration.py
View File

@ -17,7 +17,7 @@ def test_shutdown_sock_server_integration():
encoded_sock_path = urlencode_unix_socket_path(sock) encoded_sock_path = urlencode_unix_socket_path(sock)
p = subprocess.Popen( p = subprocess.Popen(
['jupyter-notebook', '--no-browser', '--sock=%s' % sock], ['jupyter-notebook', '--sock=%s' % sock],
stdout=subprocess.PIPE, stderr=subprocess.PIPE stdout=subprocess.PIPE, stderr=subprocess.PIPE
) )
@ -33,6 +33,15 @@ def test_shutdown_sock_server_integration():
# Ensure default umask is properly applied. # Ensure default umask is properly applied.
assert stat.S_IMODE(os.lstat(sock).st_mode) == 0o600 assert stat.S_IMODE(os.lstat(sock).st_mode) == 0o600
try:
subprocess.check_output(['jupyter-notebook', 'stop'], stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as e:
assert 'There is currently no server running on' in e.output.decode()
else:
raise AssertionError('expected stop command to fail due to target mis-match')
assert encoded_sock_path.encode() in subprocess.check_output(['jupyter-notebook', 'list'])
subprocess.check_output(['jupyter-notebook', 'stop', sock]) subprocess.check_output(['jupyter-notebook', 'stop', sock])
assert encoded_sock_path.encode() not in subprocess.check_output(['jupyter-notebook', 'list']) assert encoded_sock_path.encode() not in subprocess.check_output(['jupyter-notebook', 'list'])
@ -54,7 +63,7 @@ def _ensure_stopped(check_msg='There are no running servers'):
@skip_win32 @skip_win32
def test_stop_multi(): def test_stop_multi_integration():
"""Tests lifecycle behavior for mixed-mode server types w/ default ports. """Tests lifecycle behavior for mixed-mode server types w/ default ports.
Mostly suitable for local dev testing due to reliance on default port binding. Mostly suitable for local dev testing due to reliance on default port binding.
@ -72,7 +81,7 @@ def test_stop_multi():
# Unix socket. # Unix socket.
sock = UNIXSocketNotebookTestBase.sock sock = UNIXSocketNotebookTestBase.sock
p2 = subprocess.Popen( p2 = subprocess.Popen(
['jupyter-notebook', '--no-browser', '--sock=%s' % sock] ['jupyter-notebook', '--sock=%s' % sock]
) )
# Specified port # Specified port