mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-04-06 13:50:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed off by one error in get_prev_cell

Browse Source 
Not sure why this was a TODO. Maybe `find_cell_index()` returned zero at one time, but in the browsers I tested, it always returns null if not found.
This commit is contained in:
Doug Blank 2014-09-27 15:57:01 -04:00
parent d71cdbd233
commit 3997769def
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
IPython/html/static/notebook/js/notebook.js
View File

@ -465,11 +465,9 @@ define([
* @return {Cell} The previous cell
*/
Notebook.prototype.get_prev_cell = function (cell) {
// TODO: off-by-one
// nb.get_prev_cell(nb.get_cell(1)) is null
var result = null;
var index = this.find_cell_index(cell);
if (index !== null && index > 1) {
if (index !== null && index > 0) {
result = this.get_cell(index-1);
}
return result;