mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-12-09 03:50:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix rename test

Browse Source
This commit is contained in:
Jeremy Tuloup 2021-07-05 19:17:51 +02:00
parent 6e7e1eb712
commit 38401e17d0
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/build.yml vendored
View File

@ -188,7 +188,9 @@ jobs:
run: |
jlpm
jlpm run build:test
jlpm run test:ci -- --browser ${{ matrix.browser }}
jlpm run test:ci
env:
BROWSER: ${{ matrix.browser }}
- uses: actions/upload-artifact@v2
if: ${{ always() }}
with:

1
app/test/notebook.spec.ts
View File

@ -47,7 +47,6 @@ test.describe('Notebook', () => {
newName
);
await page.click('text="Rename"');
await page.waitForNavigation();
// Check the URL contains the new name
const url = page.url();

7
packages/application-extension/src/index.ts
View File

@ -394,11 +394,12 @@ const title: JupyterFrontEndPlugin<void> = {
current.activate();
}
if (!result) {
if (result === null) {
return;
}
const basename = PathExt.basename(result.path);
const newPath = current.context.path ?? result.path;
const basename = PathExt.basename(newPath);
h.textContent = basename;
if (!router) {
return;
@ -408,7 +409,7 @@ const title: JupyterFrontEndPlugin<void> = {
if (!route || !path) {
return;
}
const encoded = encodeURIComponent(result.path);
const encoded = encodeURIComponent(newPath);
router.navigate(`/retro/${route}/${encoded}`, {
skipRouting: true
});