adresses Min comments x2

This commit is contained in:
Matthias Bussonnier 2014-12-10 20:58:01 +01:00
parent fc6f562317
commit 2d51cec3c8
5 changed files with 6 additions and 8 deletions

View File

@ -65,9 +65,8 @@ define([
};
// add a cell type drop down to the maintoolbar.
// trigged when the pseudo action `<add_celltype_list>` is
// triggered when the pseudo action `<add_celltype_list>` is
// encountered when building a toolbar.
// there supposed to be only one of these, but many should work in most cases;
MainToolBar.prototype.add_celltype_list = function () {
var that = this;
var sel = $('<select/>')

View File

@ -113,7 +113,7 @@ define([
'home':'Home',
'end':'End',
'space':'Space',
'backspace,':'Backspace',
'backspace':'Backspace',
};
var humanize_map;
@ -240,8 +240,6 @@ define([
var shortcut = '';
if(s.shortcut){
shortcut = prettify(humanize_sequence(s.shortcut));
} else {
console.error('[debug] - nothing for', s)
}
return $('<div>').addClass('quickhelp').
append($('<span/>').addClass('shortcut_key').append($(shortcut))).

View File

@ -98,7 +98,7 @@ define([
_pseudo_action = list.slice(1,-1);
this[_pseudo_action]();
} catch (e) {
console.warn('ouch, calling ', _pseudo_action, 'does not seem to work...:');
console.warn('ouch, calling ', _pseudo_action, 'does not seem to work...:', e);
}
return ;
}

View File

@ -67,7 +67,7 @@ casper.notebook_test(function () {
cell.clear_output();
cell.set_text('a=13; print(a)');
// 'run button' is the first of the forth group in default config.
$('#maintoolbar .btn-group:nth(4) .btn:first').click()
$('#maintoolbar .btn-group:nth(4) .btn:first').click();
});
this.wait_for_output(0);

View File

@ -29,7 +29,8 @@ casper.notebook_test(function () {
$('#cell_type').val('markdown').change();
var cell = IPython.notebook.get_selected_cell();
cell.set_text('*Baz*');
$('#maintoolbar .btn-group:nth(4) .btn:first').click()
// 'run button' is the first of the forth group in default config.
$('#maintoolbar .btn-group:nth(4) .btn:first').click();
return cell.get_rendered();
});
this.test.assertEquals(output.trim(), '<p><em>Baz</em></p>', 'Markdown toolbar items work.');