From 2d51cec3c8a3575e83a0460c5e7ddce34a43d7d9 Mon Sep 17 00:00:00 2001
From: Matthias Bussonnier <bussonniermatthias@gmail.com>
Date: Wed, 10 Dec 2014 20:58:01 +0100
Subject: [PATCH] adresses Min comments x2

---
 IPython/html/static/notebook/js/maintoolbar.js | 3 +--
 IPython/html/static/notebook/js/quickhelp.js   | 4 +---
 IPython/html/static/notebook/js/toolbar.js     | 2 +-
 IPython/html/tests/notebook/execute_code.js    | 2 +-
 IPython/html/tests/notebook/markdown.js        | 3 ++-
 5 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/IPython/html/static/notebook/js/maintoolbar.js b/IPython/html/static/notebook/js/maintoolbar.js
index c790ed8a8..132daa1c0 100644
--- a/IPython/html/static/notebook/js/maintoolbar.js
+++ b/IPython/html/static/notebook/js/maintoolbar.js
@@ -65,9 +65,8 @@ define([
     };
     
     // add a cell type drop down to the maintoolbar.
-    // trigged when the pseudo action `<add_celltype_list>` is
+    // triggered when the pseudo action `<add_celltype_list>` is
     // encountered when building a toolbar.
-    // there supposed to be only one of these, but many should work in most cases;
     MainToolBar.prototype.add_celltype_list = function () {
         var that = this;
         var sel = $('<select/>')
diff --git a/IPython/html/static/notebook/js/quickhelp.js b/IPython/html/static/notebook/js/quickhelp.js
index 57f24f52a..7f4879e8e 100644
--- a/IPython/html/static/notebook/js/quickhelp.js
+++ b/IPython/html/static/notebook/js/quickhelp.js
@@ -113,7 +113,7 @@ define([
         'home':'Home',
         'end':'End',
         'space':'Space',
-        'backspace,':'Backspace',
+        'backspace':'Backspace',
         };
     
     var humanize_map;
@@ -240,8 +240,6 @@ define([
         var shortcut = '';
         if(s.shortcut){
             shortcut = prettify(humanize_sequence(s.shortcut));
-        } else {
-            console.error('[debug] -  nothing for', s)
         }
         return $('<div>').addClass('quickhelp').
             append($('<span/>').addClass('shortcut_key').append($(shortcut))).
diff --git a/IPython/html/static/notebook/js/toolbar.js b/IPython/html/static/notebook/js/toolbar.js
index fd0b1f06f..4a1c5266a 100644
--- a/IPython/html/static/notebook/js/toolbar.js
+++ b/IPython/html/static/notebook/js/toolbar.js
@@ -98,7 +98,7 @@ define([
                 _pseudo_action = list.slice(1,-1);
                 this[_pseudo_action]();
             } catch (e) {
-                console.warn('ouch, calling ', _pseudo_action, 'does not seem to work...:');
+                console.warn('ouch, calling ', _pseudo_action, 'does not seem to work...:', e);
             }
             return ;
         }
diff --git a/IPython/html/tests/notebook/execute_code.js b/IPython/html/tests/notebook/execute_code.js
index a9551c97e..569a5d14a 100644
--- a/IPython/html/tests/notebook/execute_code.js
+++ b/IPython/html/tests/notebook/execute_code.js
@@ -67,7 +67,7 @@ casper.notebook_test(function () {
         cell.clear_output();
         cell.set_text('a=13; print(a)');
         // 'run button' is the first of the forth group in default config.
-        $('#maintoolbar  .btn-group:nth(4) .btn:first').click()
+        $('#maintoolbar  .btn-group:nth(4) .btn:first').click();
     });
     
     this.wait_for_output(0);
diff --git a/IPython/html/tests/notebook/markdown.js b/IPython/html/tests/notebook/markdown.js
index 51a22e0ad..6a554cdcd 100644
--- a/IPython/html/tests/notebook/markdown.js
+++ b/IPython/html/tests/notebook/markdown.js
@@ -29,7 +29,8 @@ casper.notebook_test(function () {
         $('#cell_type').val('markdown').change();
         var cell = IPython.notebook.get_selected_cell();
         cell.set_text('*Baz*');
-        $('#maintoolbar  .btn-group:nth(4) .btn:first').click()
+        // 'run button' is the first of the forth group in default config.
+        $('#maintoolbar  .btn-group:nth(4) .btn:first').click();
         return cell.get_rendered();
     });
     this.test.assertEquals(output.trim(), '<p><em>Baz</em></p>', 'Markdown toolbar items work.');