mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-19 13:20:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add comments emphasizing the order of steps in widget box remove() methods

Browse Source
This commit is contained in:
Jason Grout 2014-11-25 01:44:35 +00:00
parent e7065d5a9f
commit 247ebf16f0
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
IPython/html/static/widgets/js/widget_box.js
View File

@ -79,6 +79,9 @@ define([
},
remove: function() {
// We remove this widget before removing the children as an optimization
// we want to remove the entire container from the DOM first before
// removing each individual child separately.
BoxView.__super__.remove.apply(this, arguments);
this.children_views.remove();
},

6
IPython/html/static/widgets/js/widget_selectioncontainer.js
View File

@ -128,6 +128,9 @@ define([
},
remove: function() {
// We remove this widget before removing the children as an optimization
// we want to remove the entire container from the DOM first before
// removing each individual child separately.
AccordionView.__super__.remove.apply(this, arguments);
this.children_views.remove();
},
@ -252,6 +255,9 @@ define([
},
remove: function() {
// We remove this widget before removing the children as an optimization
// we want to remove the entire container from the DOM first before
// removing each individual child separately.
TabView.__super__.remove.apply(this, arguments);
this.children_views.remove();
},