mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add comments indicating when dependency check can be removed

Browse Source
This commit is contained in:
Kevin Bates 2020-04-02 10:52:50 -07:00
parent 53d4d08813
commit 1fc9bc0b72
No known key found for this signature in database
GPG Key ID: ADCCD5840EE5145F
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
notebook/notebookapp.py
View File

@ -1392,10 +1392,10 @@ class NotebookApp(JupyterApp):
) )
# Ensure the appropriate version of Python and jupyter_client is available. # Ensure the appropriate version of Python and jupyter_client is available.
if isinstance(self.kernel_manager, AsyncMappingKernelManager): if isinstance(self.kernel_manager, AsyncMappingKernelManager):
if sys.version_info < (3, 6): if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
raise ValueError("You are using `AsyncMappingKernelManager` in Python 3.5 (or lower) " raise ValueError("You are using `AsyncMappingKernelManager` in Python 3.5 (or lower) "
"which is not supported. Please upgrade Python to 3.6+ or change kernel managers.") "which is not supported. Please upgrade Python to 3.6+ or change kernel managers.")
if not async_kernel_mgmt_available: if not async_kernel_mgmt_available: # Can be removed once jupyter_client >= 6.1 is required.
raise ValueError("You are using `AsyncMappingKernelManager` without an appropriate " raise ValueError("You are using `AsyncMappingKernelManager` without an appropriate "
"jupyter_client installed! Please upgrade jupyter_client or change kernel managers.") "jupyter_client installed! Please upgrade jupyter_client or change kernel managers.")
self.log.info("Asynchronous kernel management has been configured to use '{}'.". self.log.info("Asynchronous kernel management has been configured to use '{}'.".

4
notebook/services/kernels/tests/test_kernels_api.py
View File

@ -201,9 +201,9 @@ class AsyncKernelAPITest(KernelAPITest):
@classmethod @classmethod
def setup_class(cls): def setup_class(cls):
if not async_testing_enabled: if not async_testing_enabled: # Can be removed once jupyter_client >= 6.1 is required.
raise SkipTest("AsyncKernelAPITest tests skipped due to down-level jupyter_client!") raise SkipTest("AsyncKernelAPITest tests skipped due to down-level jupyter_client!")
if sys.version_info < (3, 6): if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
raise SkipTest("AsyncKernelAPITest tests skipped due to Python < 3.6!") raise SkipTest("AsyncKernelAPITest tests skipped due to Python < 3.6!")
super(AsyncKernelAPITest, cls).setup_class() super(AsyncKernelAPITest, cls).setup_class()

4
notebook/services/sessions/tests/test_sessions_api.py
View File

@ -271,9 +271,9 @@ class AsyncSessionAPITest(SessionAPITest):
@classmethod @classmethod
def setup_class(cls): def setup_class(cls):
if not async_testing_enabled: if not async_testing_enabled: # Can be removed once jupyter_client >= 6.1 is required.
raise SkipTest("AsyncSessionAPITest tests skipped due to down-level jupyter_client!") raise SkipTest("AsyncSessionAPITest tests skipped due to down-level jupyter_client!")
if sys.version_info < (3, 6): if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
raise SkipTest("AsyncSessionAPITest tests skipped due to Python < 3.6!") raise SkipTest("AsyncSessionAPITest tests skipped due to Python < 3.6!")
super(AsyncSessionAPITest, cls).setup_class() super(AsyncSessionAPITest, cls).setup_class()