mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-04-06 13:50:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug where views child to other views would not have cell information

Browse Source
This commit is contained in:
Jonathan Frederic 2014-01-22 12:04:53 -08:00
parent f06a0a7d5e
commit 1b8b6b3a88
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
IPython/html/static/notebook/js/widgetmanager.js
View File

@ -90,10 +90,18 @@
}
},
WidgetManager.prototype.create_view = function(model, options) {
WidgetManager.prototype.create_view = function(model, options, view) {
var view_name = model.get('view_name');
var ViewType = WidgetManager._view_types[view_name];
if (ViewType !== undefined && ViewType !== null) {
// If a view is passed into the method, use that view's cell as
// the cell for the view that is created.
options = options || {};
if (view !== undefined) {
options.cell = view.options.cell;
}
var parameters = {model: model, options: options};
var view = new ViewType(parameters);
view.render();

2
IPython/html/static/notebook/js/widgets/widget.js
View File

@ -261,7 +261,7 @@ function(WidgetManager, Underscore, Backbone){
// TODO: this is hacky, and makes the view depend on this cell attribute and widget manager behavior
// it would be great to have the widget manager add the cell metadata
// to the subview without having to add it here.
var child_view = this.model.widget_manager.create_view(child_model, options || {});
var child_view = this.model.widget_manager.create_view(child_model, options || {}, this);
this.child_views[child_model.id] = child_view;
return child_view;
},