mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-24 12:05:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

ip_address only accepts unicode on Python 2

Browse Source 
ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2

need to decode it, otherwise 127.0.0.1 won't be treated as local
This commit is contained in:
Min RK 2018-07-31 13:51:24 +02:00
parent ceaf1c1158
commit 1901eeac63
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
notebook/base/handlers.py
View File

@ -35,7 +35,7 @@ from notebook._sysinfo import get_sys_info
from traitlets.config import Application
from ipython_genutils.path import filefind
from ipython_genutils.py3compat import string_types
from ipython_genutils.py3compat import string_types, PY3
import notebook
from notebook._tz import utcnow
@ -427,6 +427,10 @@ class IPythonHandler(AuthenticatedHandler):
if host.startswith('[') and host.endswith(']'):
host = host[1:-1]
if not PY3:
# ip_address only accepts unicode on Python 2
host = host.decode('utf8', 'replace')
try:
addr = ipaddress.ip_address(host)
except ValueError: