mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-02-05 12:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

actually catch failure to load widget state

Browse Source 
load callback was called directly,
rather than in promise function that catches errors
This commit is contained in:
Min RK 2015-02-28 15:10:48 -08:00
parent 2b95955079
commit 17ee541add
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
IPython/html/static/widgets/js/manager.js
View File

@ -33,7 +33,9 @@ define([
// registered.
var that = this;
if (WidgetManager._load_callback) {
Promise.resolve(WidgetManager._load_callback.call(this)).then(function(state) {
Promise.resolve().then(function () {
return WidgetManager._load_callback.call(that);
}).then(function(state) {
that.set_state(state);
}).catch(utils.reject('Error loading widget manager state', true));
}
@ -95,7 +97,9 @@ define([
// Use the load callback to immediately load widget states.
WidgetManager._managers.forEach(function(manager) {
if (load_callback) {
Promise.resolve(load_callback.call(manager)).then(function(state) {
Promise.resolve().then(function () {
return load_callback.call(manager);
}).then(function(state) {
manager.set_state(state);
}).catch(utils.reject('Error loading widget manager state', true));
}