mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-02-11 12:30:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

encode file name in Content-Disposition when it contains non-ascii characters

Browse Source
This commit is contained in:
wenjun.swj 2016-07-25 11:51:34 +08:00
parent 52bade4f01
commit 17a7fe76a9
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
notebook/base/handlers.py
View File

@ -22,7 +22,7 @@ except ImportError:
from jinja2 import TemplateNotFound
from tornado import web
from tornado import gen
from tornado import gen, escape
from tornado.log import app_log
from notebook._sysinfo import get_sys_info
@ -412,7 +412,7 @@ class AuthenticatedFileHandler(IPythonHandler, web.StaticFileHandler):
if os.path.splitext(path)[1] == '.ipynb':
name = path.rsplit('/', 1)[-1]
self.set_header('Content-Type', 'application/json')
self.set_header('Content-Disposition','attachment; filename="%s"' % name)
self.set_header('Content-Disposition','attachment; filename="%s"' % escape.url_escape(name))
return web.StaticFileHandler.get(self, path)

4
notebook/files/handlers.py
View File

@ -12,7 +12,7 @@ except ImportError: #PY2
from base64 import decodestring as decodebytes
from tornado import web
from tornado import web, escape
from notebook.base.handlers import IPythonHandler
@ -39,7 +39,7 @@ class FilesHandler(IPythonHandler):
model = cm.get(path, type='file', content=include_body)
if self.get_argument("download", False):
self.set_header('Content-Disposition','attachment; filename="%s"' % name)
self.set_header('Content-Disposition','attachment; filename="%s"' % escape.urlescape(name))
# get mimetype from filename
if name.endswith('.ipynb'):