mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-19 13:20:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

use jQuery attr instead of setAttribute

Browse Source 
when appending images.

This was an optimization with no apparent performance benefit.
This commit is contained in:
MinRK 2014-01-27 14:36:33 -08:00
parent 2cbb633cb4
commit 0d1536c390
1 changed files with 5 additions and 6 deletions

11
IPython/html/static/notebook/js/outputarea.js

@ -617,17 +617,16 @@ var IPython = (function (IPython) {
var set_width_height = function (img, md, mime) {
// set width and height of an img element from metadata
var height = _get_metadata_key(md, 'height', mime);
if (height !== undefined) img.setAttribute('height', height);
if (height !== undefined) img.attr('height', height);
var width = _get_metadata_key(md, 'width', mime);
if (width !== undefined) img.setAttribute('width', width);
if (width !== undefined) img.attr('width', width);
};
OutputArea.prototype.append_png = function (png, md, element) {
var type = 'image/png';
var toinsert = this.create_output_subarea(md, "output_png", type);
var img = $("<img/>");
img[0].setAttribute('src','data:image/png;base64,'+png);
set_width_height(img[0], md, 'image/png');
var img = $("<img/>").attr('src','data:image/png;base64,'+png);
set_width_height(img, md, 'image/png');
this._dblclick_to_reset_size(img);
toinsert.append(img);
element.append(toinsert);
@ -638,7 +637,7 @@ var IPython = (function (IPython) {
var type = 'image/jpeg';
var toinsert = this.create_output_subarea(md, "output_jpeg", type);
var img = $("<img/>").attr('src','data:image/jpeg;base64,'+jpeg);
set_width_height(img[0], md, 'image/jpeg');
set_width_height(img, md, 'image/jpeg');
this._dblclick_to_reset_size(img);
toinsert.append(img);
element.append(toinsert);