mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-30 12:11:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

log exceptions in Comm handlers

Browse Source
This commit is contained in:
MinRK 2013-10-11 09:03:51 +02:00
parent 8bcf95404d
commit 0a89edc641
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
IPython/html/static/services/kernels/js/comm.js
View File

@ -49,7 +49,7 @@ var IPython = (function (IPython) {
// Unregister a target function for a given target name
delete this.targets[target_name];
};
CommManager.prototype.register_comm = function (comm) {
// Register a comm in the mapping
this.comms[comm.comm_id] = comm;
@ -74,7 +74,13 @@ var IPython = (function (IPython) {
}
var comm = new Comm(content.comm_id);
this.register_comm(comm);
f(comm, msg);
try {
f(comm, msg);
} catch (e) {
console.log("Exception opening new comm:", e, msg);
comm.close();
this.unregister_comm(comm);
}
};
CommManager.prototype.comm_close = function (msg) {
@ -84,7 +90,11 @@ var IPython = (function (IPython) {
return;
}
delete this.comms[content.comm_id];
comm.handle_close(msg);
try {
comm.handle_close(msg);
} catch (e) {
console.log("Exception closing comm: ", e, msg);
}
};
CommManager.prototype.comm_msg = function (msg) {
@ -93,7 +103,11 @@ var IPython = (function (IPython) {
if (comm === undefined) {
return;
}
comm.handle_msg(msg);
try {
comm.handle_msg(msg);
} catch (e) {
console.log("Exception handling comm msg: ", e, msg);
}
};
//-----------------------------------------------------------------------