mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-12-27 04:20:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add a brief sleep after shutting down sessions in test teardown

Browse Source 
This fixes a test failure for me on my Windows VM. See the comment for
details.
This commit is contained in:
Thomas Kluyver 2014-12-15 12:45:45 -08:00
parent 420fee5e4c
commit 0178e2add0
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
IPython/html/services/sessions/tests/test_sessions_api.py
View File

@ -6,6 +6,7 @@ import os
import json import json
import requests import requests
import shutil import shutil
import time
pjoin = os.path.join pjoin = os.path.join
@ -71,6 +72,14 @@ class SessionAPITest(NotebookTestBase):
def tearDown(self): def tearDown(self):
for session in self.sess_api.list().json(): for session in self.sess_api.list().json():
self.sess_api.delete(session['id']) self.sess_api.delete(session['id'])
# This is necessary in some situations on Windows: without it, it
# fails to delete the directory because something is still using it. I
# think there is a brief period after the kernel terminates where
# Windows still treats its working directory as in use. On my Windows
# VM, 0.01s is not long enough, but 0.1s appears to work reliably.
# -- TK, 15 December 2014
time.sleep(0.1)
shutil.rmtree(pjoin(self.notebook_dir.name, 'foo'), shutil.rmtree(pjoin(self.notebook_dir.name, 'foo'),
ignore_errors=True) ignore_errors=True)