Report test errors correctly

cxx4/test_att.cpp

@@ -828,8 +828,7 @@ int main()
     }
   catch (NcException& e)
     {
-      cout << "unknown error"<<endl;
-      e.what();
-      return e.errorCode();
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
     }
 }

cxx4/test_classic.cpp

@@ -52,7 +52,7 @@ int main()
    }
    catch(NcException& e)
    {
-      cout << "Error!\n";
-      return e.errorCode();
+     cout << e.what() << endl;
+     return EXIT_FAILURE;
    }
 }

cxx4/test_dim.cpp

@@ -326,8 +326,7 @@ int main()
     }
   catch (NcException& e)
     {
-      cout <<"\n";
-      e.what();
-      return e.errorCode();
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
     }
 }

cxx4/test_filter.cpp

@@ -70,8 +70,7 @@ int main()
     }
   catch (NcException& e)
     {
-      cout << "unknown error"<<endl;
-      e.what();
+      cout << e.what() << endl;
       return e.errorCode();
     }
 }

cxx4/test_group.cpp

@@ -386,8 +386,7 @@ try
   }
  catch (NcException& e)
    {
-     cout << "unknown error"<<endl;
-     e.what();
-     return e.errorCode();
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
    }
 }

cxx4/test_type.cpp

@@ -530,7 +530,6 @@ try
       vlenPointer[0] = 1;
       vlenPointer[1] = 31;
       vlenPointer[2] = -20;
-      dummyData2.mem1[0];
       dummyData2.mem1[0].p = vlenPointer;
       dummyData2.mem1[0].len=3;
       //      vlenPointer = new short int[2];
@@ -558,8 +557,7 @@ try
 }
 catch (NcException& e)
   {
-    cout << "unknown error"<<endl;
-    cout << e.what();
-    exit(e.errorCode());
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
   }
 }

cxx4/test_type2.cpp

@@ -53,8 +53,7 @@ try
 }
 catch (NcException& e)
   {
-    cout << "unknown error"<<endl;
-    e.what();
+    cout << e.what() << endl;
     return e.errorCode();
   }
 }

cxx4/test_type3.cpp

@@ -88,8 +88,7 @@ try
   }
  catch (NcException& e)
    {
-     cout << "unknown error"<<endl;
-     e.what();
+     cout << e.what() << endl;
      return e.errorCode();
    }
 }

cxx4/test_type4.cpp

@@ -72,8 +72,7 @@ try
   }
  catch (NcException& e)
    {
-     cout << "unknown error"<<endl;
-     e.what();
+     cout << e.what() << endl;
      return e.errorCode();
    }
 }

cxx4/test_type5.cpp

@@ -78,8 +78,7 @@ try
   }
  catch (NcException& e)
    {
-     cout << "unknown error"<<endl;
-     e.what();
+     cout << e.what() << endl;
      return e.errorCode();
    }
 }

cxx4/test_var.cpp

@@ -811,8 +811,7 @@ int main()
     }
   catch (NcException& e)
     {
-      cout << "unknown error"<<endl;
-      e.what();
-      return e.errorCode();
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
     }
 }

cxx4/test_var2.cpp

@@ -186,8 +186,7 @@ int main()
     }
   catch (NcException& e)
     {
-      cout << "unknown error"<<endl;
-      e.what();
-      return e.errorCode();
+      cout << e.what() << endl;
+      return EXIT_FAILURE;
     }
 }