mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support. |
||
|---|---|---|
| .. | ||
| expected3 | ||
| expectremote3 | ||
| expecttds3 | ||
| nocacheremote3 | ||
| special3 | ||
| testdata3 | ||
| CMakeLists.txt | ||
| findtestserver.c.in | ||
| Makefile.am | ||
| run_ncdap_tests.sh | ||
| t_auth.c | ||
| t_dap3a.c | ||
| t_dap3b.c | ||
| t_dap3c.c | ||
| t_dap.c | ||
| t_misc.c | ||
| t_ncf330.c | ||
| t_srcdir.h | ||
| test_cvt.c | ||
| test_environment.c | ||
| test_nstride_cached.c | ||
| test_partvar2.c | ||
| test_partvar.c | ||
| test_vara.c | ||
| test_varm3.c | ||
| testauth.old | ||
| testauth.sh | ||
| testauth.sh.old | ||
| testbasicauth.sh | ||
| testcontainerauth.sh | ||
| testurl.sh | ||
| tst_ber.sh | ||
| tst_curlopt.sh | ||
| tst_filelists.sh | ||
| tst_fillmismatch.sh | ||
| tst_formatx.sh | ||
| tst_longremote3.sh | ||
| tst_ncdap3.sh | ||
| tst_ncdap_shared.sh | ||
| tst_ncdap.sh | ||
| tst_nocache3.sh | ||
| tst_remote3.sh | ||
| tst_remote.sh | ||
| tst_special.sh | ||
| tst_tds.sh | ||
| tst_urls.sh | ||
| tst_utils.sh | ||