mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
125 lines
4.7 KiB
Bash
Executable File
125 lines
4.7 KiB
Bash
Executable File
#!/bin/sh
|
|
# This shell script tests ncdump for netcdf-4
|
|
# Ed Hartnett, Dennis Heimbigner, Ward Fisher
|
|
|
|
if test "x$srcdir" = x ; then srcdir=`pwd`; fi
|
|
. ../test_common.sh
|
|
|
|
set -e
|
|
|
|
# Remove the version information from _NCProperties
|
|
cleanncprops() {
|
|
src="$1"
|
|
dst="$2"
|
|
rm -f $dst
|
|
cat $src \
|
|
| sed -e 's/_SuperblockVersion = 1/_SuperblockVersion = 0/' \
|
|
| sed -e 's/\(netcdflibversion\|netcdf\)=.*|/\1=NNNN|/' \
|
|
| sed -e 's/\(hdf5libversion\|hdf5\)=.*"/\1=HHHH"/' \
|
|
| grep -v '_NCProperties' \
|
|
| cat >$dst
|
|
}
|
|
|
|
ERR() {
|
|
RES=$?
|
|
if [ $RES -ne 0 ]; then
|
|
echo "Error found: $RES"
|
|
exit $RES
|
|
fi
|
|
}
|
|
|
|
echo ""
|
|
echo "*** Testing ncgen and ncdump for netCDF-4 format."
|
|
${NCGEN} -k nc4 -b -o tst_netcdf4_c0_4.nc ${ncgenc04} ;ERR
|
|
${NCDUMP} -n c1 tst_netcdf4_c0_4.nc | sed 's/e+0/e+/g' > tst_netcdf4_c1_4.cdl ; ERR
|
|
diff -b tst_netcdf4_c1_4.cdl $srcdir/ref_ctest1_nc4.cdl ; ERR
|
|
|
|
echo "*** Creating test output tst_netcdf4_c0.nc."
|
|
${NCGEN} -k nc7 -b -o tst_netcdf4_c0.nc ${ncgenc0} ; ERR
|
|
|
|
echo "*** Testing that program tst_h_rdc0 can read tst_netcdf4_c0.nc."
|
|
${execdir}/tst_h_rdc0 ; ERR
|
|
|
|
echo "*** Running tst_create_files.c to create test files."
|
|
${execdir}/tst_create_files ; ERR
|
|
echo "*** Testing tst_create_files output for netCDF-4 features."
|
|
${NCDUMP} tst_solar_1.nc | sed 's/e+0/e+/g' > tst_solar_1.cdl ; ERR
|
|
diff -b tst_solar_1.cdl $srcdir/ref_tst_solar_1.cdl ; ERR
|
|
${NCDUMP} tst_solar_2.nc | sed 's/e+0/e+/g' > tst_solar_2.cdl ; ERR
|
|
diff -b tst_solar_2.cdl $srcdir/ref_tst_solar_2.cdl ; ERR
|
|
|
|
echo "*** Running tst_group_data.c to create test files."
|
|
${execdir}/tst_group_data ; ERR
|
|
${NCDUMP} tst_group_data.nc | sed 's/e+0/e+/g' > tst_group_data.cdl ; ERR
|
|
diff -b tst_group_data.cdl $srcdir/ref_tst_group_data.cdl ; ERR
|
|
|
|
echo "*** Testing -v option with absolute name and groups..."
|
|
${NCDUMP} -v g2/g3/var tst_group_data.nc | sed 's/e+0/e+/g' > tst_group_data.cdl ; ERR
|
|
diff -b tst_group_data.cdl $srcdir/ref_tst_group_data_v23.cdl ; ERR
|
|
|
|
echo "*** Testing -v option with relative name and groups..."
|
|
${NCDUMP} -v var,var2 tst_group_data.nc | sed 's/e+0/e+/g' > tst_group_data.cdl ; ERR
|
|
diff -b tst_group_data.cdl $srcdir/ref_tst_group_data.cdl ; ERR
|
|
|
|
echo "*** Running tst_enum_data.c to create test files."
|
|
${execdir}/tst_enum_data ; ERR
|
|
${NCDUMP} tst_enum_data.nc | sed 's/e+0/e+/g' > tst_enum_data.cdl ; ERR
|
|
diff -b tst_enum_data.cdl $srcdir/ref_tst_enum_data.cdl ; ERR
|
|
|
|
echo "*** Running tst_opaque_data.c to create test files."
|
|
${execdir}/tst_opaque_data ; ERR
|
|
${NCDUMP} tst_opaque_data.nc | sed 's/e+0/e+/g' > tst_opaque_data.cdl ; ERR
|
|
diff -b tst_opaque_data.cdl $srcdir/ref_tst_opaque_data.cdl ; ERR
|
|
|
|
if test "x$NC_VLEN_NOTEST" = x ; then
|
|
echo "*** Running tst_vlen_data.c to create test files."
|
|
${execdir}/tst_vlen_data ; ERR
|
|
${NCDUMP} tst_vlen_data.nc | sed 's/e+0/e+/g' > tst_vlen_data.cdl ; ERR
|
|
diff -b tst_vlen_data.cdl $srcdir/ref_tst_vlen_data.cdl ; ERR
|
|
fi
|
|
|
|
echo "*** Running tst_comp.c to create test files."
|
|
${execdir}/tst_comp ; ERR
|
|
${NCDUMP} tst_comp.nc | sed 's/e+0/e+/g' > tst_comp.cdl ; ERR
|
|
diff -b tst_comp.cdl $srcdir/ref_tst_comp.cdl ; ERR
|
|
|
|
echo "*** Running tst_nans.c to create test files."
|
|
${execdir}/tst_nans ; ERR
|
|
${NCDUMP} tst_nans.nc | sed 's/e+0/e+/g' > tst_nans.cdl ; ERR
|
|
diff -b tst_nans.cdl $srcdir/ref_tst_nans.cdl ; ERR
|
|
|
|
# Do unicode test only if it exists => BUILD_UTF8 is true
|
|
if test -f ./tst_unicode -o -f ./tst_unicode.exe ; then
|
|
echo "*** dumping tst_unicode.nc to tst_unicode.cdl..."
|
|
${execdir}/tst_unicode ; ERR
|
|
${NCDUMP} tst_unicode.nc | sed 's/e+0/e+/g' > tst_unicode.cdl ; ERR
|
|
#echo "*** comparing tst_unicode.cdl with ref_tst_unicode.cdl..."
|
|
#diff -b tst_unicode.cdl $srcdir/ref_tst_unicode.cdl
|
|
fi
|
|
|
|
echo "*** Running tst_special_atts.c to create test files."
|
|
${execdir}/tst_special_atts ; ERR
|
|
${NCDUMP} -c -s tst_special_atts.nc > tst_special_atts.cdl ; ERR
|
|
cleanncprops tst_special_atts.cdl tst_special_atts.tmp
|
|
cleanncprops $srcdir/ref_tst_special_atts.cdl ref_tst_special_atts.tmp
|
|
echo "*** comparing tst_special_atts.cdl with ref_tst_special_atts.cdl..."
|
|
diff -b tst_special_atts.tmp ref_tst_special_atts.tmp ; ERR
|
|
|
|
#echo ""
|
|
#echo "*** Testing ncdump on file with corrupted header "
|
|
#rm -f ./ignore_tst_netcdf4
|
|
#if ${NCDUMP} ${srcdir}/ref_test_corrupt_magic.nc > ./ignore_tst_netcdf4 2>&1 ; then
|
|
#echo "***Fail: ncdump should have failed on ref_test_corrupt_magic.nc"
|
|
#else
|
|
#echo "***XFail: ncdump properly failed on ref_test_corrupt_magic.nc"
|
|
#fi
|
|
#rm -fr ./ignore_tst_netcdf4
|
|
|
|
# This should work, but does not. See github issue 982.
|
|
#echo "*** creating tst_output_irish_rover.cdl from ref_tst_irish_rover.nc..."
|
|
#${NCDUMP} ref_tst_irish_rover.nc > tst_output_irish_rover.cdl
|
|
|
|
rm -f *.tmp
|
|
echo "*** All ncgen and ncdump test output for netCDF-4 format passed!"
|
|
exit 0
|