mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-12-21 08:39:46 +08:00
69e84fe9f1
re: Issue The byterange handling of the following URLS fails. ### Problem 1: "https://crudata.uea.ac.uk/cru/data/temperature/HadCRUT.4.6.0.0.median.nc#mode=bytes" It turns out that byterange in hdf5 has two possible targets: S3 and not-S3 (e.g. a thredds server or the crudata URL above). Each uses a different HDF5 Virtual File Driver (VFD). I incorrectly set up the byterange code in libhdf5 so that it would choose one or the other of the two VFD's for any netcdf-c library build. The fix is to allow it to choose either one at run-time. ### Problem 2: "https://noaa-goes16.s3.amazonaws.com/ABI-L1b-RadF/2022/001/18/OR_ABI-L1b-RadF-M6C01_G16_s20220011800205_e20220011809513_c20220011809562.nc#mode=bytes,s3" When given what appears to be an S3-related URL, the netcdf-c library code converts it into a canonical, so-called "path" format. In casing out the possible input URL formats, I missed the case where the host contains the bucket ("noaa-goes16"), but not the region. So the fix was to check for this case. ## Misc. Related Changes 1. Since S3 is used in more than just NCZarr, I changed the automake/cmake options to replace "--enable-nczarr-s3" with "--enable-s3", but keeping the former option as a synonym for the latter. This also entailed cleaning up libnetcdf.settings WRT S3 support 2. Added the above URLS as additional test cases ## Misc. Un-Related Changes 1. CURLOPT_PUT is deprecated in favor to CURLOPT_UPLOAD 2. Fix some minor warnings ## Open Problems * Under Ubuntu, either libcrypto or aws-sdk-cpp has a memory leak.
59 lines
1.2 KiB
C
59 lines
1.2 KiB
C
/*********************************************************************
|
|
* Copyright 2018, UCAR/Unidata
|
|
* See netcdf/COPYRIGHT file for copying and redistribution conditions.
|
|
*********************************************************************/
|
|
#include "config.h"
|
|
#include <stdarg.h>
|
|
#include <stdio.h>
|
|
#ifdef HAVE_EXECINFO_H
|
|
#include <execinfo.h>
|
|
#endif
|
|
|
|
#include "hdf5debug.h"
|
|
|
|
#ifdef H5CATCH
|
|
|
|
#define STSIZE 1000
|
|
|
|
#ifdef HAVE_EXECINFO_H
|
|
#ifdef H5BACKTRACE
|
|
# if !defined _WIN32 && !defined __CYGWIN__
|
|
static void* stacktrace[STSIZE];
|
|
# endif
|
|
#endif
|
|
#endif
|
|
|
|
int
|
|
nch5breakpoint(int err)
|
|
{
|
|
#ifdef HAVE_EXECINFO_H
|
|
#ifdef H5BACKTRACE
|
|
# if !defined _WIN32 && !defined __CYGWIN__
|
|
int count = 0;
|
|
char** trace = NULL;
|
|
int i;
|
|
|
|
count = backtrace(stacktrace,STSIZE);
|
|
trace = backtrace_symbols(stacktrace, STSIZE);
|
|
fprintf(stderr,"backtrace:\n");
|
|
for(i=0;i<count;i++)
|
|
fprintf(stderr,"[%03d] %s\n",i,trace[i]);
|
|
# if 0
|
|
if(trace != NULL) free(trace);
|
|
# endif
|
|
# endif
|
|
#endif
|
|
#endif
|
|
return ncbreakpoint(err);
|
|
}
|
|
|
|
int
|
|
nch5throw(int err, int line)
|
|
{
|
|
if(err == 0) return err;
|
|
fprintf(stderr,">>> hdf5throw: line=%d err=%d\n",line,err); fflush(stderr);
|
|
return nch5breakpoint(err);
|
|
}
|
|
#endif
|
|
|