mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| h5_err_macros.h | ||
| Makefile.am | ||
| ref_tst_compounds.nc | ||
| ref_tst_h_compounds2.h5 | ||
| ref_tst_h_compounds.h5 | ||
| run_par_tests.sh | ||
| tst_h_atts3.c | ||
| tst_h_atts4.c | ||
| tst_h_atts.c | ||
| tst_h_compounds2.c | ||
| tst_h_compounds.c | ||
| tst_h_dimscales1.c | ||
| tst_h_dimscales2.c | ||
| tst_h_dimscales3.c | ||
| tst_h_dimscales4.c | ||
| tst_h_dimscales.c | ||
| tst_h_endian_float.c | ||
| tst_h_enums.c | ||
| tst_h_files2.c | ||
| tst_h_files4.c | ||
| tst_h_files.c | ||
| tst_h_grps.c | ||
| tst_h_ints.c | ||
| tst_h_mem.c | ||
| tst_h_opaques.c | ||
| tst_h_par.c | ||
| tst_h_strings1.c | ||
| tst_h_strings2.c | ||
| tst_h_strings.c | ||
| tst_h_vars2.c | ||
| tst_h_vars3.c | ||
| tst_h_vars.c | ||
| tst_h_vl.c | ||
| tst_h_wrt_cmp.c | ||