mirror of
https://github.com/Unidata/netcdf-c.git
synced 2025-01-18 15:55:12 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support. |
||
|---|---|---|
| .. | ||
| bad_cdf5_begin.nc | ||
| CMakeLists.txt | ||
| error.c | ||
| error.h | ||
| f03tst_open_mem.nc | ||
| large_files.c | ||
| make_test_file.sh | ||
| Makefile.am | ||
| nc_enddef.cdl | ||
| nc_sync.cdl | ||
| nc_test.c | ||
| nc_test.html | ||
| quick_large_files.c | ||
| ref_tst_diskless2.cdl | ||
| run_cdf5.sh | ||
| run_diskless2.sh | ||
| run_diskless5.sh | ||
| run_diskless.sh | ||
| run_inmemory.sh | ||
| run_mmap.sh | ||
| run_pnetcdf_test.sh | ||
| t_nc_p5.c | ||
| t_nc.c | ||
| test_get.m4 | ||
| test_put.m4 | ||
| test_read.m4 | ||
| test_write.m4 | ||
| testnc3perf.c | ||
| tests.h | ||
| tst_addvar.c | ||
| tst_atts3.c | ||
| tst_big_rvar.c | ||
| tst_big_var2.c | ||
| tst_big_var6.c | ||
| tst_big_var.c | ||
| tst_cdf5_begin.c | ||
| tst_cdf5format.c | ||
| tst_def_var_fill.c | ||
| tst_default_format_pnetcdf.c | ||
| tst_default_format.c | ||
| tst_diskless2.c | ||
| tst_diskless3.c | ||
| tst_diskless4.c | ||
| tst_diskless5.c | ||
| tst_diskless5.cdl | ||
| tst_diskless6.c | ||
| tst_diskless.c | ||
| tst_err_enddef.c | ||
| tst_formats.c | ||
| tst_formatx_pnetcdf.c | ||
| tst_global_fillval.c | ||
| tst_inmemory.c | ||
| tst_inq_type.c | ||
| tst_large_cdf5.c | ||
| tst_large.c | ||
| tst_max_var_dims.c | ||
| tst_meta.c | ||
| tst_misc.c | ||
| tst_names.c | ||
| tst_nofill2.c | ||
| tst_nofill3.c | ||
| tst_nofill.c | ||
| tst_norm.c | ||
| tst_open_cdf5.c | ||
| tst_open_mem.c | ||
| tst_parallel2.c | ||
| tst_pnetcdf.c | ||
| tst_small.c | ||
| tst_utf8_phrases.c | ||
| tst_utf8_validate.c | ||
| util.c | ||