mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-12-09 08:11:38 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| ceconstraints.h | ||
| CMakeLists.txt | ||
| err_macros.h | ||
| fbits.h | ||
| hdf4dispatch.h | ||
| hdf5internal.h | ||
| Makefile.am | ||
| nc3dispatch.h | ||
| nc3internal.h | ||
| nc4dispatch.h | ||
| nc4internal.h | ||
| nc_hashmap.h | ||
| nc_logging.h | ||
| nc_tests.h | ||
| nc.h | ||
| ncauth.h | ||
| ncbytes.h | ||
| ncconfigure.h | ||
| ncdap.h | ||
| ncdimscale.h | ||
| ncdispatch.h | ||
| ncexternl.h | ||
| ncfilter.h | ||
| nchashmap.h | ||
| ncindex.h | ||
| nclist.h | ||
| nclog.h | ||
| ncoffsets.h | ||
| ncrc.h | ||
| nctestserver.h | ||
| nctime.h | ||
| ncuri.h | ||
| ncutf8.h | ||
| ncwinpath.h | ||
| netcdf_aux.h | ||
| netcdf_f.h | ||
| netcdf_mem.h | ||
| netcdf_meta.h.in | ||
| netcdf_par.h | ||
| netcdf.h | ||
| onstack.h | ||
| rnd.h | ||
| XGetopt.h | ||