mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
fb40a72b45
re: Issue https://github.com/Unidata/netcdf-c/issues/2685 re: PR https://github.com/Unidata/netcdf-c/pull/2179 As noted in PR https://github.com/Unidata/netcdf-c/pull/2179, the old code did not allow for reclaiming instances of types, nor for properly copying them. That PR provided new functions capable of reclaiming/copying instances of arbitrary types. However, as noted by Issue https://github.com/Unidata/netcdf-c/issues/2685, using these most general functions resulted in a significant performance degradation, even for common cases. This PR attempts to mitigate the cost of using the general reclaim/copy functions in two ways. First, the previous functions operating at the top level by using ncid and typeid arguments. These functions were augmented with equivalent versions that used the netcdf-c library internal data structures to allow direct access to needed information. These new functions are used internally to the library. The second mitigation involves optimizing the internal functions by providing early tests for common cases. This avoids unnecessary recursive function calls. The overall result is a significant improvement in speed by a factor of roughly twenty -- your mileage may vary. These optimized functions are still not as fast as the original (more limited) functions, but they are getting close. Additional optimizations are possible. But the cost is a significant "uglification" of the code that I deemed a step too far, at least for now. ## Misc. Changes 1. Added a test case to check the proper reclamation/copy of complex types. 2. Found and fixed some places where nc_reclaim/copy should have been used. 3. Replaced, in the netcdf-c library, (almost all) occurrences of nc_reclaim_copy with calls to NC_reclaim/copy. This plus the optimizations is the primary speed-up mechanism. 4. In DAP4, the metadata is held in a substrate in-memory file; this required some changes so that the reclaim/copy code accessed that substrate dispatcher rather than the DAP4 dispatcher. 5. Re-factored and isolated the code that computes if a type is (transitively) variable-sized or not. 6. Clean up the reclamation code in ncgen; adding the use of nc_reclaim exposed some memory problems. |
||
|---|---|---|
| .. | ||
| bindata.c | ||
| bytebuffer.c | ||
| bytebuffer.h | ||
| c0_4.cdl | ||
| c0.cdl | ||
| c5.cdl | ||
| cdata.c | ||
| cdfdata.c | ||
| CMakeLists.txt | ||
| cmldata.c | ||
| compound_datasize_test2.cdl | ||
| compound_datasize_test.cdl | ||
| ctests.sh | ||
| cvt.c | ||
| data.c | ||
| data.h | ||
| debug.c | ||
| debug.h | ||
| depend | ||
| dump.c | ||
| dump.h | ||
| env | ||
| escapes.c | ||
| f77data.c | ||
| foo.cdl | ||
| ftests.sh | ||
| genbin.c | ||
| genc.c | ||
| genchar.c | ||
| gencml.c | ||
| generate.c | ||
| generate.h | ||
| generr.c | ||
| generr.h | ||
| genf77.c | ||
| genj.c | ||
| genjjni.c | ||
| genjstd.c | ||
| genlib.c | ||
| genlib.h | ||
| getfill.c | ||
| includes.h | ||
| internals.html | ||
| jdata.c | ||
| jdatajni.c | ||
| jdatastd.c | ||
| jtests.sh | ||
| lfs-tests | ||
| list.c | ||
| list.h | ||
| main_cpp.cpp | ||
| main.c | ||
| Makefile.am | ||
| makeparser.sh | ||
| ncf199.cdl | ||
| ncf345.cdl | ||
| ncgen.1 | ||
| ncgen.h | ||
| ncgen.l | ||
| ncgen.y | ||
| ncgenl.c | ||
| ncgeny.c | ||
| ncgeny.h | ||
| odom.c | ||
| odom.h | ||
| ref_camrun.cdl | ||
| run_tests2.sh | ||
| semantics.c | ||
| tst_gattenum.cdl | ||
| tst_usuffix.cdl | ||
| util.c | ||
| util.h | ||