mirror of
https://github.com/Unidata/netcdf-c.git
synced 2025-01-18 15:55:12 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
116 lines
2.4 KiB
Bash
Executable File
116 lines
2.4 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
#NOP=1
|
|
#NOS=1
|
|
#NOB=1
|
|
|
|
#SHOW=1
|
|
#DBG=1
|
|
#GDB=1
|
|
|
|
# if this is part of a distcheck action, then this script
|
|
# will be executed in a different directory
|
|
# than the one containing it; so capture the path to this script
|
|
# as the location of the source directory.
|
|
|
|
# capture the build directory
|
|
# Do a hack to remove e.g. c: for CYGWIN
|
|
|
|
if test "x$srcdir" = x ; then srcdir=`pwd`; fi
|
|
. ../test_common.sh
|
|
|
|
# Figure our dst server; if none, then just stop
|
|
DTS=`${execdir}/findtestserver dap2 dts`
|
|
if test "x$DTS" = "x" ; then
|
|
echo "WARNING: Cannot locate test server for dts"
|
|
exit 1
|
|
fi
|
|
|
|
OCLOGFILE=stderr
|
|
if test "x$DBG" = x1 ; then
|
|
SHOW=1
|
|
fi
|
|
|
|
URL="$DTS/test.03"
|
|
|
|
PREFIX="[log][show=fetch]"
|
|
SUFFIX="log&show=fetch"
|
|
BOTHP="[log][show=fetch]"
|
|
BOTHS="noprefetch&fetch=disk"
|
|
STRLEN="[maxstrlen=16]"
|
|
|
|
locreset () {
|
|
rm -f ./tmp_testurl ./errtmp_testurl
|
|
}
|
|
|
|
buildurl () {
|
|
front="$1"
|
|
back="$2"
|
|
url="${front}${URL}"
|
|
if test "x$back" != x ; then
|
|
url="${url}#${back}"
|
|
fi
|
|
}
|
|
|
|
pass=1
|
|
|
|
if test "x$GDB" = x1 ; then
|
|
NCDUMP="gdb --args $NCDUMP"
|
|
fi
|
|
|
|
# Initialize
|
|
locreset
|
|
|
|
if test "x$NOP" != x1 ; then
|
|
echo "***Testing url prefix parameters"
|
|
buildurl "$PREFIX" ""
|
|
# Invoke ncdump to extract the URL
|
|
|
|
echo "command: ${NCDUMP} -h $url"
|
|
|
|
${NCDUMP} -h "$url" >./tmp_testurl 2> ./errtmp_testurl
|
|
if test "x${SHOW}" = x1 ; then cat ./tmp ; fi
|
|
|
|
# Test that maxstrlen works as alias for stringlength
|
|
echo "***Testing maxstrlen=stringlength alias"
|
|
buildurl "$STRLEN" ""
|
|
# Invoke ncdump to extract the URL
|
|
echo "command: ${NCDUMP} -h $url"
|
|
${NCDUMP} "$url" >./tmp_testurl 2> ./errtmp_testurl
|
|
if test "x${SHOW}" = x1 ; then cat ./tmp_testurl ; fi
|
|
# Look for the value of maxStrlen in output cdl
|
|
if ! fgrep -i "maxstrlen = 16" ./tmp_testurl ; then
|
|
echo "***Fail: maxStrlen not recognized"
|
|
fgrep -i "maxstrlen16 = 16" ./tmp_testurl > ./errtmp_testurl
|
|
fi
|
|
|
|
fi
|
|
|
|
locreset
|
|
if test "x$NOS" != x1 ; then
|
|
echo "***Testing url suffix parameters"
|
|
buildurl "" "$SUFFIX"
|
|
# Invoke ncdump to extract the URL
|
|
${NCDUMP} -h "$url" >./tmp_testurl 2> ./errtmp_testurl
|
|
if test "x${SHOW}" = x1 ; then cat ./tmp_testurl ; fi
|
|
fi
|
|
|
|
locreset
|
|
|
|
if test "x$NOB" != x1 ; then
|
|
echo "***Testing url prefix+suffix parameters"
|
|
buildurl "$BOTHP" "$BOTHS"
|
|
# Invoke ncdump to extract the URL
|
|
${NCDUMP} -h "$url" >./tmp_testurl 2> ./errtmp_testurl
|
|
if test "x${SHOW}" = x1 ; then cat ./tmp_testurl ; fi
|
|
fi
|
|
|
|
locreset
|
|
|
|
if test "x$pass" = x0 ; then
|
|
echo "***FAIL"
|
|
exit 1
|
|
fi
|
|
echo "***PASS"
|
|
exit 0
|