mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-21 03:13:42 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
59 lines
1.0 KiB
Bash
Executable File
59 lines
1.0 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
if test "x$srcdir" = x ; then srcdir=`pwd`; fi
|
|
. ../test_common.sh
|
|
|
|
set -e
|
|
|
|
if test "x$srcdir" = x ; then srcdir=`pwd`; fi
|
|
. ../test_common.sh
|
|
|
|
# Get the target OS and CPU
|
|
CPU=`uname -p`
|
|
OS=`uname`
|
|
|
|
# Test diskless on a reasonably large file size
|
|
|
|
# Try a large in-memory file; two instances at once may be needed when doing realloc
|
|
#SIZE=1000000000
|
|
SIZE=500000000
|
|
|
|
FILE4=tst_diskless4.nc
|
|
|
|
# Uncomment to get timing
|
|
#TIME=time
|
|
|
|
# Create the reference ncdump output for tst_diskless4
|
|
rm -fr ref_tst_diskless4.cdl
|
|
cat >ref_tst_diskless4.cdl <<EOF
|
|
netcdf tst_diskless4 {
|
|
dimensions:
|
|
dim = 500000000 ;
|
|
variables:
|
|
byte var0(dim) ;
|
|
}
|
|
EOF
|
|
|
|
echo ""
|
|
rm -f $FILE4
|
|
$TIME ./tst_diskless4 $SIZE create
|
|
# Validate it
|
|
${NCDUMP} -h $FILE4 |diff -w - ref_tst_diskless4.cdl
|
|
|
|
echo ""
|
|
rm -f $FILE4
|
|
$TIME ./tst_diskless4 $SIZE creatediskless
|
|
# Validate it
|
|
${NCDUMP} -h $FILE4 |diff -w - ref_tst_diskless4.cdl
|
|
|
|
echo ""
|
|
$TIME ./tst_diskless4 $SIZE open
|
|
|
|
echo ""
|
|
$TIME ./tst_diskless4 $SIZE opendiskless
|
|
|
|
# cleanup
|
|
rm -f $FILE4 tst_diskless4.cdl ref_tst_diskless4.cdl
|
|
|
|
exit
|