mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-21 03:13:42 +08:00
0ee68a3263
The fix includes the following changes. 1. Checking and using the default file format at file create time is now done only when the create mode (argument cmode) does not include any format related flags, i.e. NC_64BIT_OFFSET, NC_64BIT_DATA, NC_CLASSIC_MODEL, and NC_NETCDF4. 2. Adjustment of cmode based on the default format is now done in NC_create() only. The idea is to adjust cmode before entering the dispatcher's file create subroutine. 3. Any adjustment of cmode is removed from all I/O dispatchers, i.e. NC4_create(), NC3_create(), and NCP_create(). 4. Checking for illegal cmode has been done in check_create_mode() called in NC_create(). This commit removes the redundant checking from NCP_create(). 5. Remove PnetCDF tests in nc_test/tst_names.c, so it can focus on testing all classic formats and netCDF4 formats. Two new test programs are added. They can be used to test netCDF with and without this commit. 1. nc_test/tst_default_format.c 2. nc_test/tst_default_format_pnetcdf.c (use when PnetCDF is enabled).
221 lines
7.3 KiB
C
221 lines
7.3 KiB
C
#include "config.h"
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <netcdf.h>
|
|
|
|
#define ERR { \
|
|
if (err != NC_NOERR) { \
|
|
printf("Error at %s line %d: %s\n", __FILE__, __LINE__, \
|
|
nc_strerror(err)); \
|
|
nerrs++; \
|
|
} \
|
|
}
|
|
|
|
static int default_format;
|
|
|
|
static int
|
|
create_check(char *fname, int cmode, int exp_format)
|
|
{
|
|
int nerrs=0, err, ncid, format;
|
|
char *exp_str;
|
|
|
|
switch (exp_format) {
|
|
case NC_FORMAT_CLASSIC: exp_str="NC_FORMAT_CLASSIC"; break;
|
|
case NC_FORMAT_64BIT_OFFSET: exp_str="NC_FORMAT_64BIT_OFFSET"; break;
|
|
case NC_FORMAT_64BIT_DATA: exp_str="NC_FORMAT_64BIT_DATA"; break;
|
|
case NC_FORMAT_NETCDF4: exp_str="NC_FORMAT_NETCDF4"; break;
|
|
case NC_FORMAT_NETCDF4_CLASSIC:
|
|
exp_str="NC_FORMAT_NETCDF4_CLASSIC";break;
|
|
default: break;
|
|
}
|
|
|
|
/* create a file */
|
|
cmode |= NC_CLOBBER;
|
|
err = nc_create(fname, cmode, &ncid); ERR
|
|
err = nc_close(ncid); ERR
|
|
|
|
/* open the file and check its format */
|
|
err = nc_open(fname, NC_NOWRITE, &ncid); ERR
|
|
err = nc_inq_format(ncid, &format); ERR
|
|
if (format != exp_format) {
|
|
char *f_str, *d_str;
|
|
switch (format) {
|
|
case NC_FORMAT_CLASSIC: f_str = "NC_FORMAT_CLASSIC";
|
|
break;
|
|
case NC_FORMAT_64BIT_OFFSET: f_str = "NC_FORMAT_64BIT_OFFSET";
|
|
break;
|
|
case NC_FORMAT_64BIT_DATA: f_str = "NC_FORMAT_64BIT_DATA";
|
|
break;
|
|
case NC_FORMAT_NETCDF4: f_str = "NC_FORMAT_NETCDF4";
|
|
break;
|
|
case NC_FORMAT_NETCDF4_CLASSIC: f_str = "NC_FORMAT_NETCDF4_CLASSIC";
|
|
break;
|
|
default: break;
|
|
}
|
|
switch (default_format) {
|
|
case NC_FORMAT_CLASSIC: d_str = "NC_FORMAT_CLASSIC";
|
|
break;
|
|
case NC_FORMAT_64BIT_OFFSET: d_str = "NC_FORMAT_64BIT_OFFSET";
|
|
break;
|
|
case NC_FORMAT_64BIT_DATA: d_str = "NC_FORMAT_64BIT_DATA";
|
|
break;
|
|
case NC_FORMAT_NETCDF4: d_str = "NC_FORMAT_NETCDF4";
|
|
break;
|
|
case NC_FORMAT_NETCDF4_CLASSIC: d_str = "NC_FORMAT_NETCDF4_CLASSIC";
|
|
break;
|
|
default: break;
|
|
}
|
|
|
|
printf("Error at %s line %d: default is %s and expect %s but got %s\n",
|
|
__FILE__, __LINE__, d_str, exp_str, f_str);
|
|
nerrs++;
|
|
}
|
|
err = nc_close(ncid); ERR
|
|
return nerrs;
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
char *fname="tst_default_format.nc";
|
|
int err, nerrs=0, ncid, cmode, format;
|
|
|
|
if (argc == 2) fname = argv[1];
|
|
|
|
default_format = NC_FORMAT_CLASSIC;
|
|
|
|
/* check illegal cmode */
|
|
cmode = NC_64BIT_OFFSET | NC_64BIT_DATA;
|
|
err = nc_create(fname, cmode, &ncid);
|
|
if (err != NC_EINVAL) {
|
|
printf("Error at %s line %d: expect NC_EINVAL but got %d\n",
|
|
__FILE__, __LINE__, err);
|
|
nerrs++;
|
|
}
|
|
|
|
/* check illegal cmode */
|
|
cmode = NC_NETCDF4 | NC_64BIT_OFFSET;
|
|
err = nc_create(fname, cmode, &ncid);
|
|
if (err != NC_EINVAL) {
|
|
printf("Error at %s line %d: expect NC_EINVAL but got %d\n",
|
|
__FILE__, __LINE__, err);
|
|
nerrs++;
|
|
}
|
|
|
|
/* check illegal cmode */
|
|
cmode = NC_MPIIO | NC_MPIPOSIX;
|
|
err = nc_create(fname, cmode, &ncid);
|
|
if (err != NC_EINVAL) {
|
|
printf("Error at %s line %d: expect NC_EINVAL but got %d\n",
|
|
__FILE__, __LINE__, err);
|
|
nerrs++;
|
|
}
|
|
|
|
/* check illegal cmode */
|
|
cmode = NC_MPIIO | NC_DISKLESS;
|
|
err = nc_create(fname, cmode, &ncid);
|
|
if (err != NC_EINVAL) {
|
|
printf("Error at %s line %d: expect NC_EINVAL but got %d\n",
|
|
__FILE__, __LINE__, err);
|
|
nerrs++;
|
|
}
|
|
|
|
/* check illegal cmode */
|
|
cmode = NC_MPIPOSIX | NC_DISKLESS;
|
|
err = nc_create(fname, cmode, &ncid);
|
|
if (err != NC_EINVAL) {
|
|
printf("Error at %s line %d: expect NC_EINVAL but got %d\n",
|
|
__FILE__, __LINE__, err);
|
|
nerrs++;
|
|
}
|
|
|
|
/* create a file in CDF1 format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_CLASSIC);
|
|
|
|
/* create a file in CDF2 format */
|
|
cmode = NC_64BIT_OFFSET;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
|
|
#ifdef ENABLE_CDF5
|
|
/* create a file in CDF5 format */
|
|
cmode = NC_64BIT_DATA;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_DATA);
|
|
#endif
|
|
|
|
/* set default file format to NC_FORMAT_64BIT_OFFSET ------------------*/
|
|
default_format = NC_FORMAT_64BIT_OFFSET;
|
|
err = nc_set_default_format(default_format, NULL); ERR
|
|
|
|
/* create a file in default format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
|
|
#ifdef ENABLE_CDF5
|
|
/* create a file in CDF5 format (this should ignore default) */
|
|
cmode = NC_64BIT_DATA;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_DATA);
|
|
#endif
|
|
|
|
#ifdef ENABLE_CDF5
|
|
/* set default file format to NC_FORMAT_64BIT_DATA --------------------*/
|
|
default_format = NC_FORMAT_64BIT_DATA;
|
|
err = nc_set_default_format(default_format, NULL); ERR
|
|
|
|
/* create a file in default format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_DATA);
|
|
|
|
/* create a file in CDF2 format (this should ignore default) */
|
|
cmode = NC_64BIT_OFFSET;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
#endif
|
|
|
|
#ifdef USE_NETCDF4
|
|
/* set default file format to NC_FORMAT_NETCDF4 -----------------------*/
|
|
default_format = NC_FORMAT_NETCDF4;
|
|
err = nc_set_default_format(default_format, NULL); ERR
|
|
|
|
/* create a file in default format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_NETCDF4);
|
|
|
|
/* create a file in CDF2 format (this should ignore default) */
|
|
cmode = NC_64BIT_OFFSET;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
|
|
/* set default file format to NC_FORMAT_NETCDF4_CLASSIC ---------------*/
|
|
default_format = NC_FORMAT_NETCDF4_CLASSIC;
|
|
err = nc_set_default_format(default_format, NULL); ERR
|
|
|
|
/* create a file in default format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_NETCDF4_CLASSIC);
|
|
|
|
/* create a file in NETCDF4 format (this should ignore default) */
|
|
cmode = NC_NETCDF4;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_NETCDF4);
|
|
|
|
/* create a file in CDF2 format (this should ignore default) */
|
|
cmode = NC_64BIT_OFFSET;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
|
|
/* set default file format to NC_FORMAT_NETCDF4 -----------------------*/
|
|
default_format = NC_FORMAT_NETCDF4;
|
|
err = nc_set_default_format(default_format, NULL); ERR
|
|
|
|
/* create a file in default format */
|
|
cmode = 0;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_NETCDF4);
|
|
|
|
/* create a file in NETCDF4 format (this should ignore default) */
|
|
cmode = NC_NETCDF4 | NC_CLASSIC_MODEL;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_NETCDF4_CLASSIC);
|
|
|
|
/* create a file in CDF2 format (this should ignore default) */
|
|
cmode = NC_64BIT_OFFSET;
|
|
nerrs += create_check(fname, cmode, NC_FORMAT_64BIT_OFFSET);
|
|
#endif
|
|
|
|
return (nerrs > 0);
|
|
}
|