mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
29 lines
962 B
C
29 lines
962 B
C
/*********************************************************************
|
|
* Copyright 2009, UCAR/Unidata
|
|
* See netcdf/COPYRIGHT file for copying and redistribution conditions.
|
|
*********************************************************************/
|
|
/* $Id: generr.h,v 1.2 2010/05/24 19:59:57 dmh Exp $ */
|
|
/* $Header: /upc/share/CVS/netcdf-3/ncgen/generr.h,v 1.2 2010/05/24 19:59:57 dmh Exp $ */
|
|
|
|
#ifndef GENERR_H
|
|
#define GENERR_H
|
|
|
|
#include <stdarg.h>
|
|
|
|
extern int error_count;
|
|
|
|
#if 0
|
|
#define vastart(argv,fmt) va_start(argv,fmt)
|
|
#define vaend(argv,fmt) va_end(argv)
|
|
#endif
|
|
|
|
extern void vderror(const char *fmt, va_list argv);
|
|
extern void vdwarn(const char *fmt, va_list argv);
|
|
extern void derror(const char *fmt, ...);
|
|
extern int panic(const char* fmt, ...);
|
|
extern void nprintf(char* buffer, size_t size, const char *fmt, ...);
|
|
extern void semerror(const int, const char *fmt, ...);
|
|
extern void semwarn(const int, const char *fmt, ...);
|
|
|
|
#endif /*GENERR_H*/
|