mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-12-27 08:49:16 +08:00
6901206927
re: https://github.com/Unidata/netcdf-c/issues/1827 The issue is partly resolved by this PR. The proximate problem appears to be that the semantics of mkstemp in **nix is different than the semantics of _mktemp_s in Windows. I had thought they were the same but that is incorrect. The _mktemp_s function will only produce 26 different files and so the netcdf temp file code will fail after about that many iterations. So, to solve this, I created my own version of mkstemp for windows that uses a random number generator. This appears to solve the reported issue. I also added the testcase ncdap_test/test_manyurls but made it conditional on --enable-dap-long-tests because it is very slow. I did note that the provided test program now fails after some 800 iterations with a libcurl error claiming it cannot resolve the host name. My belief is that the library is just running out of resources at this point: too many open curl handles or some such. I doubt if this failure is fixable. So bottom line is that it is really important to do nc_close when you are finished with a file. Misc. Other Changes: 1. I took the opportunity to clean up some bad string hacks in the code. Specifically * change all uses of strncat to strlcat * remove old string hacks: occoncat and occopycat 2. Add heck to see if test.opendap.org is running and if not, then skip test 3. Make CYGWIN use TEMP environment variable
126 lines
2.6 KiB
C
126 lines
2.6 KiB
C
/*********************************************************************
|
|
* Copyright 2018, UCAR/Unidata
|
|
* See netcdf/COPYRIGHT file for copying and redistribution conditions.
|
|
* $Header: /upc/share/CVS/netcdf-3/ncgen/generr.c,v 1.1 2009/09/25 18:22:22 dmh Exp $
|
|
*********************************************************************/
|
|
|
|
#include "includes.h"
|
|
#include <ctype.h> /* for isprint() */
|
|
|
|
#ifndef vsnprintf
|
|
extern int vsnprintf(char*, size_t, const char*, va_list ap);
|
|
#endif
|
|
|
|
int error_count;
|
|
|
|
/*
|
|
* For logging error conditions.
|
|
* Designed to be called by other vararg procedures
|
|
*/
|
|
void
|
|
vderror(const char *fmt, va_list argv)
|
|
{
|
|
(void) vdwarn(fmt,argv);
|
|
error_count++;
|
|
}
|
|
|
|
/*
|
|
* For logging error conditions.
|
|
* Designed to be called by other vararg procedures
|
|
*/
|
|
void
|
|
vdwarn(const char *fmt, va_list argv)
|
|
{
|
|
(void) vfprintf(stderr,fmt,argv) ;
|
|
(void) fputc('\n',stderr) ;
|
|
(void) fflush(stderr); /* to ensure log files are current */
|
|
}
|
|
|
|
void
|
|
derror(const char *fmt, ...)
|
|
{
|
|
va_list argv;
|
|
va_start(argv,fmt);
|
|
vderror(fmt,argv);
|
|
}
|
|
|
|
/* Report version errors */
|
|
void
|
|
verror(const char *fmt, ...)
|
|
{
|
|
char newfmt[2048];
|
|
va_list argv;
|
|
va_start(argv,fmt);
|
|
strncpy(newfmt,"netCDF classic: not supported: ",sizeof(newfmt));
|
|
strlcat(newfmt,fmt,sizeof(newfmt));
|
|
vderror(newfmt,argv);
|
|
va_end(argv);
|
|
}
|
|
|
|
void
|
|
semwarn(const int lno, const char *fmt, ...)
|
|
{
|
|
va_list argv;
|
|
va_start(argv,fmt);
|
|
(void)fprintf(stderr,"%s: %s line %d: ", progname, cdlname, lno);
|
|
vdwarn(fmt,argv);
|
|
}
|
|
|
|
void
|
|
semerror(const int lno, const char *fmt, ...)
|
|
{
|
|
va_list argv;
|
|
va_start(argv,fmt);
|
|
(void)fprintf(stderr,"%s: %s line %d: ", progname, cdlname, lno);
|
|
vderror(fmt,argv);
|
|
finalize_netcdf(1); /* immediately fatal */
|
|
}
|
|
|
|
/* Capture potential version errors */
|
|
static char* markcdf4_msg = NULL;
|
|
void
|
|
markcdf4(const char* msg)
|
|
{
|
|
enhanced_flag = 1;
|
|
if(markcdf4_msg == NULL)
|
|
markcdf4_msg = (char*)msg;
|
|
}
|
|
|
|
char*
|
|
getmarkcdf4(void)
|
|
{
|
|
return markcdf4_msg;
|
|
}
|
|
|
|
/* Capture potential version errors */
|
|
static char* markcdf5_msg = NULL;
|
|
void
|
|
markcdf5(const char* msg)
|
|
{
|
|
cdf5_flag = 1;
|
|
if(markcdf5_msg == NULL)
|
|
markcdf5_msg = (char*)msg;
|
|
}
|
|
|
|
char*
|
|
getmarkcdf5(void)
|
|
{
|
|
return markcdf5_msg;
|
|
}
|
|
|
|
/**************************************************/
|
|
/* Provide a version of snprintf that panics if*/
|
|
/* the buffer is overrun*/
|
|
|
|
void
|
|
nprintf(char* buffer, size_t size, const char *fmt, ...)
|
|
{
|
|
long written;
|
|
va_list args;
|
|
va_start(args,fmt);
|
|
written = vsnprintf(buffer,size,fmt,args);
|
|
if(written < 0 || written >= size) {
|
|
PANIC("snprintf failure");
|
|
}
|
|
}
|