netcdf-c/nczarr_test/tst_utils.c
Dennis Heimbigner 0b7a5382e7 Codify cross-platform file paths
The netcdf-c code has to deal with a variety of platforms:
Windows, OSX, Linux, Cygwin, MSYS, etc.  These platforms differ
significantly in the kind of file paths that they accept.  So in
order to handle this, I have created a set of replacements for
the most common file system operations such as _open_ or _fopen_
or _access_ to manage the file path differences correctly.

A more limited version of this idea was already implemented via
the ncwinpath.h and dwinpath.c code. So this can be viewed as a
replacement for that code. And in path in many cases, the only
change that was required was to replace '#include <ncwinpath.h>'
with '#include <ncpathmgt.h>' and then replace file operation
calls with the NCxxx equivalent from ncpathmgr.h Note that
recently, the ncwinpath.h was renamed ncpathmgmt.h, so this pull
request should not require dealing with winpath.

The heart of the change is include/ncpathmgmt.h, which provides
alternate operations such as NCfopen or NCaccess and which properly
parse and rebuild path arguments to work for the platform on which
the code is executing. This mostly matters for Windows because of the
way that it uses backslash and drive letters, as compared to *nix*.
One important feature is that the user can do string manipulations
on a file path without having to worry too much about the platform
because the path management code will properly handle most mixed cases.
So one can for example concatenate a path suffix that uses forward
slashes to a Windows path and have it work correctly.

The conversion code is in libdispatch/dpathmgr.c, and the
important function there is NCpathcvt which does the proper
conversions to the local path format.

As a rule, most code should just replace their file operations with
the corresponding NCxxx ones defined in include/ncpathmgmt.h. These
NCxxx functions all call NCpathcvt on their path arguments before
executing the actual file operation.

In some rare cases, the client may need to directly use NCpathcvt,
but this should be avoided as much as possible. If there is a need
for supporting a new file operation not already in ncpathmgmt.h, then
use the code in dpathmgr.c as a template. Also please notify Unidata
so we can include it as a formal part or our supported operations.
Also, if you see an operation in the library that is not using the
NCxxx form, then please submit an issue so we can fix it.

Misc. Changes:
* Clean up the utf8 testing code; it is impossible to get some
  tests to work under windows using shell scripts; the args do
  not pass as utf8 but as some other encoding.
* Added an extra utf8 test case: test_unicode_path.sh
* Add a true test for HDF5 1.10.6 or later because as noted in
  PR https://github.com/Unidata/netcdf-c/pull/1794,
  HDF5 changed its Windows file path handling.
2021-03-04 13:41:31 -07:00

468 lines
12 KiB
C

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <netcdf.h>
#include <ncpathmgr.h>
#include <nclist.h>
#include <ncuri.h>
#include <nclog.h>
#ifdef HAVE_GETOPT_H
#include <getopt.h>
#endif
#ifdef _WIN32
#include "XGetopt.h"
#endif
#ifdef HAVE_HDF5_H
#include <hdf5.h>
#include <H5DSpublic.h>
#endif
#include "tst_utils.h"
Options* options = NULL;
Metadata* meta = NULL;
NClist* capture = NULL;
static void
CHECKRANK(int r)
{
if(options->rank == 0)
options->rank = r;
else if(r != options->rank) {
fprintf(stderr,"FAIL: options->rank mismatch\n");
exit(1);
}
}
int
getoptions(int* argcp, char*** argvp)
{
int ret = NC_NOERR;
int i,c;
const char* p;
/* initialize */
if(options == NULL) {
if((options = calloc(1,sizeof(Options))) == NULL)
{ret = NC_ENOMEM; goto done;}
}
/* Set defaults */
options->mode = 0; /* classic netcdf-3 */
while ((c = getopt(*argcp, *argvp, "T:34c:d:e:f:n:m:p:s:D:O:X:")) != EOF) {
switch(c) {
case 'T':
nctracelevel(atoi(optarg));
break;
case '3':
options->mode = 0;
break;
case '4':
options->mode = NC_NETCDF4;
break;
case 'c':
CHECKRANK(parsevector(optarg,options->chunks));
options->flags |= HAS_CHUNKS;
break;
case 'd':
CHECKRANK(parsevector(optarg,options->dimlens));
options->flags |= HAS_DIMLENS;
break;
case 'e':
CHECKRANK(parsevector(optarg,options->count));
options->flags |= HAS_COUNT;
break;
case 'f':
CHECKRANK(parsevector(optarg,options->start));
options->flags |= HAS_START;
break;
case 'p':
CHECKRANK(parsevector(optarg,options->stop));
options->flags |= HAS_STOP;
break;
case 'm':
CHECKRANK(parsevector(optarg,options->max));
options->flags |= HAS_MAX;
break;
case 'n':
CHECKRANK(atoi(optarg));
break;
case 's':
CHECKRANK(parsevector(optarg,options->stride));
options->flags |= HAS_STRIDE;
break;
case 'D':
options->debug = (unsigned)atoi(optarg);
break;
case 'O':
for(p=optarg;*p;p++) {
switch (*p) {
case 'r': options->op = Read; break;
case 'w': options->op = Write; break;
case 'W': options->wholechunk = 1; break;
case 'o': options->op = Odom; break;
default: fprintf(stderr,"Unknown operation '%c'\n",*p); exit(1);
}
} break;
case 'X':
if(strcmp(optarg,"opt")==0) {
options->optimize = 1;
} else if(strncmp(optarg,"wd",2)==0) {
options->wdebug = atoi(optarg+2);
}
break;
case '?':
fprintf(stderr,"unknown option\n");
exit(1);
}
}
/* get file argument */
*argcp -= optind;
*argvp += optind;
if(*argcp > 0) {
char* p = NC_backslashUnescape((*argvp)[0]);
strcpy(options->file,filenamefor(p));
nullfree(p);
}
/* Figure out the FORMATX for this file */
if(options->file) {
NCURI* uri = NULL;
ncuriparse(options->file,&uri);
if(uri == NULL) { /* not a url */
switch (options->mode) {
default: /* fall thru to default */
case 0: options->formatx = NC_FORMATX_NC3; break;
case NC_NETCDF4: options->formatx = NC_FORMATX_NC4; break;
}
} else {
options->formatx = NC_FORMATX_NCZARR; /* assume */
ncurifree(uri);
}
}
if(options->debug) {
const char* fmt = "unknown";
switch(options->formatx) {
case NC_FORMATX_NC3: fmt = "NC3"; break;
case NC_FORMATX_NC4: fmt = "NC4"; break;
case NC_FORMATX_NCZARR: fmt = "NCZARR"; break;
default: break;
}
fprintf(stderr,"Formatx: %s\n",fmt);
}
#ifndef _WIN32
if(options->wdebug) {
char s[64];
snprintf(s,sizeof(s),"%u",options->wdebug);
setenv("NCZ_WDEBUG",s,1);
}
if(options->optimize) {
unsetenv("NCZ_NOOPTIMIZE");
} else {
setenv("NCZ_NOOPTIMIZE","1",1);
}
#endif
/* Default some vectors */
if(!(options->flags & HAS_DIMLENS)) {for(i=0;i<NC_MAX_VAR_DIMS;i++) {options->dimlens[i] = 4;}}
if(!(options->flags & HAS_CHUNKS)) {for(i=0;i<NC_MAX_VAR_DIMS;i++) {options->chunks[i] = 2;}}
if(!(options->flags & HAS_STRIDE)) {for(i=0;i<NC_MAX_VAR_DIMS;i++) {options->stride[i] = 1;}}
/* Computed Defaults */
if((options->flags & HAS_COUNT) && (options->flags & HAS_STOP)) {
fprintf(stderr,"cannot specify both count and stop\n");
ERR(NC_EINVAL);
}
if(!(options->flags & HAS_COUNT) && !(options->flags & HAS_STOP)) {
for(i=0;i<options->rank;i++)
options->count[i] = (options->dimlens[i]+options->stride[i]-1)/options->stride[i];
}
if((options->flags & HAS_COUNT) && !(options->flags & HAS_STOP)) {
for(i=0;i<options->rank;i++)
options->stop[i] = (options->count[i] * options->stride[i]);
}
if(!(options->flags & HAS_COUNT) && (options->flags & HAS_STOP)) {
for(i=0;i<options->rank;i++)
options->count[i] = ((options->stop[i]+options->stride[i]-1) / options->stride[i]);
}
if(!(options->flags & HAS_MAX)) {for(i=0;i<NC_MAX_VAR_DIMS;i++) {options->max[i] = options->stop[i];}}
if(options->debug) {
#ifdef USE_HDF5
H5Eset_auto2(H5E_DEFAULT,(H5E_auto2_t)H5Eprint,stderr);
#endif
}
done:
return ret;
}
int
getmetadata(int create)
{
int ret = NC_NOERR;
char dname[NC_MAX_NAME];
int i;
if(meta == NULL) {
if((meta = calloc(1,sizeof(Metadata)))==NULL)
{ret = NC_ENOMEM; goto done;}
/* Non-zero defaults */
meta->fill = -1;
}
if(create) {
if((ret = nc_create(options->file,options->mode,&meta->ncid))) goto done;
for(i=0;i<options->rank;i++) {
snprintf(dname,sizeof(dname),"d%d",i);
if((ret = nc_def_dim(meta->ncid,dname,options->dimlens[i],&meta->dimids[i]))) goto done;
}
if((ret = nc_def_var(meta->ncid,"v",NC_INT,options->rank,meta->dimids,&meta->varid))) goto done;
if((ret = nc_def_var_fill(meta->ncid,meta->varid,0,&meta->fill))) goto done;
if(options->formatx == NC_FORMATX_NC4 || options->formatx == NC_FORMATX_NCZARR) {
if((ret = nc_def_var_chunking(meta->ncid,meta->varid,NC_CHUNKED,options->chunks))) goto done;
}
if((ret = nc_enddef(meta->ncid))) goto done;
} else {/*Open*/
if((ret = nc_open(options->file,options->mode,&meta->ncid))) goto done;
for(i=0;i<options->rank;i++) {
snprintf(dname,sizeof(dname),"d%d",i);
if((ret = nc_inq_dimid(meta->ncid,dname,&meta->dimids[i]))) goto done;
if((ret = nc_inq_dimlen(meta->ncid,meta->dimids[i],&options->dimlens[i]))) goto done;
}
if((ret = nc_inq_varid(meta->ncid,"v",&meta->varid))) goto done;
if(options->formatx == NC_FORMATX_NC4 || options->formatx == NC_FORMATX_NCZARR) {
int storage = -1;
/* Get chunk sizes also */
if((ret = nc_inq_var_chunking(meta->ncid,meta->varid,&storage,options->chunks))) goto done;
if(storage != NC_CHUNKED) {ret = NC_EBADCHUNK; goto done;}
}
}
done:
return ret;
}
void
cleanup(void)
{
if(meta) {
if(meta->ncid) nc_close(meta->ncid);
}
nclistfreeall(capture);
nullfree(meta);
nullfree(options);
}
int
parsevector(const char* s0, size_t* vec)
{
char* s = strdup(s0);
char* p = NULL;
int i, done;
if(s0 == NULL || vec == NULL) abort();
for(done=0,p=s,i=0;!done;) {
char* q;
q = p;
p = strchr(q,',');
if(p == NULL) {p = q+strlen(q); done=1;}
*p++ = '\0';
vec[i++] = (size_t)atol(q);
}
if(s) free(s);
return i;
}
const char*
printvector(int rank, const size_t* vec)
{
size64_t v64[NC_MAX_VAR_DIMS];
int r;
for(r=0;r<rank;r++) v64[r]= (size64_t)vec[r];
return printvector64(rank,v64);
}
const char*
printvector64(int rank, const size64_t* vec)
{
char s[NC_MAX_VAR_DIMS*3+1];
int i;
char* ss = NULL;
s[0] = '\0';
for(i=0;i<rank;i++) {
char e[16];
snprintf(e,sizeof(e),"%02u",(unsigned)vec[i]);
if(i > 0) strcat(s,",");
strcat(s,e);
}
if(capture == NULL) capture = nclistnew();
ss = strdup(s);
nclistpush(capture,ss);
return ss;
}
Odometer*
odom_new(size_t rank, const size_t* start, const size_t* stop, const size_t* stride, const size_t* max)
{
int i;
Odometer* odom = NULL;
if((odom = calloc(1,sizeof(Odometer))) == NULL)
return NULL;
odom->rank = rank;
for(i=0;i<rank;i++) {
odom->start[i] = start[i];
odom->stop[i] = stop[i];
odom->stride[i] = stride[i];
odom->max[i] = (max?max[i]:stop[i]);
odom->count[i] = (odom->stop[i]+odom->stride[i]-1)/odom->stride[i];
odom->index[i] = 0;
}
return odom;
}
void
odom_free(Odometer* odom)
{
if(odom) free(odom);
}
int
odom_more(Odometer* odom)
{
return (odom->index[0] < odom->stop[0]);
}
int
odom_next(Odometer* odom)
{
size_t i;
for(i=odom->rank-1;i>=0;i--) {
odom->index[i] += odom->stride[i];
if(odom->index[i] < odom->stop[i]) break;
if(i == 0) return 0; /* leave the 0th entry if it overflows */
odom->index[i] = odom->start[i]; /* reset this position */
}
return 1;
}
/* Get the value of the odometer */
size_t*
odom_indices(Odometer* odom)
{
return odom->index;
}
size_t
odom_offset(Odometer* odom)
{
size_t offset;
int i;
offset = 0;
for(i=0;i<odom->rank;i++) {
offset *= odom->max[i];
offset += odom->index[i];
}
return offset;
}
const char*
odom_print1(Odometer* odom, int isshort)
{
static char s[4096];
static char tmp[4096];
const char* sv;
s[0] = '\0';
strcat(s,"{");
if(!isshort) {
snprintf(tmp,sizeof(tmp),"rank=%u",(unsigned)odom->rank); strcat(s,tmp);
strcat(s," start=("); sv = printvector(odom->rank,odom->start); strcat(s,sv); strcat(s,")");
strcat(s," stop=("); sv = printvector(odom->rank,odom->stop); strcat(s,sv); strcat(s,")");
strcat(s," stride=("); sv = printvector(odom->rank,odom->stride); strcat(s,sv); strcat(s,")");
strcat(s," max=("); sv = printvector(odom->rank,odom->max); strcat(s,sv); strcat(s,")");
strcat(s," count=("); sv = printvector(odom->rank,odom->count); strcat(s,sv); strcat(s,")");
}
snprintf(tmp,sizeof(tmp)," offset=%u",(unsigned)odom_offset(odom)); strcat(s,tmp);
strcat(s," indices=("); sv = printvector(odom->rank,odom->index); strcat(s,sv); strcat(s,")");
strcat(s,"}");
return s;
}
const char*
odom_print(Odometer* odom)
{
return odom_print1(odom,0);
}
const char*
odom_printshort(Odometer* odom)
{
return odom_print1(odom,1);
}
static const char* urlexts[] = {"nzf", "zip", "nz4", NULL};
const char*
filenamefor(const char* f0)
{
static char result[4096];
const char** extp;
char* p;
strcpy(result,f0); /* default */
if(nc__testurl(f0,NULL)) goto done;
/* Not a URL */
p = strrchr(f0,'.'); /* look at the extension, if any */
if(p == NULL) goto done; /* No extension */
p++;
for(extp=urlexts;*extp;extp++) {
if(strcmp(p,*extp)==0) break;
}
if(*extp == NULL) goto done; /* not found */
/* Assemble the url */
strcpy(result,"file://");
strcat(result,f0); /* core path */
strcat(result,"#mode=nczarr,");
strcat(result,*extp);
done:
return result;
}
static char s3testurl[8192];
static char* s3testurlp = NULL;
const char*
ncz_gets3testurl(void)
{
char* s;
if(s3testurlp == NULL) {
s3testurl[0] = '\0';
strcat(s3testurl,"https://");
s = getenv("NCZARR_S3_TEST_HOST");
if(s == NULL) s = "stratus.ucar.edu";
strcat(s3testurl,s);
strcat(s3testurl,"/");
s = getenv("NCZARR_S3_TEST_BUCKET");
if(s == NULL) s = "unidata-netcdf-zarr-testing";
strcat(s3testurl,s);
s3testurlp = s3testurl;
}
return s3testurlp;
}