mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-12-27 08:49:16 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
62 lines
1.1 KiB
C
62 lines
1.1 KiB
C
/*
|
|
This is part of ncgen, a utility which is part of netCDF. Copyright
|
|
2010, UCAR/Unidata. See COPYRIGHT file for copying and
|
|
redistribution conditions.
|
|
*/
|
|
|
|
/* $Id: includes.h,v 1.7 2010/05/25 18:57:00 dmh Exp $ */
|
|
/* $Header: /upc/share/CVS/netcdf-3/ncgen/includes.h,v 1.7 2010/05/25 18:57:00 dmh Exp $ */
|
|
|
|
#ifndef NCGEN_INCLUDES_H
|
|
#define NCGEN_INCLUDES_H
|
|
|
|
#include "config.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <assert.h>
|
|
#include <ctype.h> /* for isprint() */
|
|
#ifdef HAVE_UNISTD_H
|
|
#include <unistd.h>
|
|
#endif
|
|
|
|
#ifdef __SunOS
|
|
#include <strings.h>
|
|
#endif
|
|
|
|
#ifdef __hpux
|
|
#include <locale.h>
|
|
#endif
|
|
|
|
#include "list.h"
|
|
#include "bytebuffer.h"
|
|
#include "nctime.h"
|
|
|
|
/* Local Configuration flags*/
|
|
#define ENABLE_BINARY
|
|
#define ENABLE_C
|
|
#define ENABLE_F77
|
|
#define ENABLE_JAVA
|
|
|
|
#include "netcdf.h"
|
|
#include "data.h"
|
|
#include "ncgen.h"
|
|
#include "genlib.h"
|
|
#include "util.h"
|
|
#include "debug.h"
|
|
#include "nc.h"
|
|
#ifdef USE_NETCDF4
|
|
#include "nc4internal.h"
|
|
#endif
|
|
|
|
extern int specialconstants;
|
|
|
|
#undef ITERBUG
|
|
#undef CHARBUG
|
|
|
|
#undef nullfree
|
|
#define nullfree(x) {if((x)) free(x);}
|
|
|
|
#endif /* NCGEN_INCLUDES_H */
|