mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-12-21 08:39:46 +08:00
69e84fe9f1
re: Issue The byterange handling of the following URLS fails. ### Problem 1: "https://crudata.uea.ac.uk/cru/data/temperature/HadCRUT.4.6.0.0.median.nc#mode=bytes" It turns out that byterange in hdf5 has two possible targets: S3 and not-S3 (e.g. a thredds server or the crudata URL above). Each uses a different HDF5 Virtual File Driver (VFD). I incorrectly set up the byterange code in libhdf5 so that it would choose one or the other of the two VFD's for any netcdf-c library build. The fix is to allow it to choose either one at run-time. ### Problem 2: "https://noaa-goes16.s3.amazonaws.com/ABI-L1b-RadF/2022/001/18/OR_ABI-L1b-RadF-M6C01_G16_s20220011800205_e20220011809513_c20220011809562.nc#mode=bytes,s3" When given what appears to be an S3-related URL, the netcdf-c library code converts it into a canonical, so-called "path" format. In casing out the possible input URL formats, I missed the case where the host contains the bucket ("noaa-goes16"), but not the region. So the fix was to check for this case. ## Misc. Related Changes 1. Since S3 is used in more than just NCZarr, I changed the automake/cmake options to replace "--enable-nczarr-s3" with "--enable-s3", but keeping the former option as a synonym for the latter. This also entailed cleaning up libnetcdf.settings WRT S3 support 2. Added the above URLS as additional test cases ## Misc. Un-Related Changes 1. CURLOPT_PUT is deprecated in favor to CURLOPT_UPLOAD 2. Fix some minor warnings ## Open Problems * Under Ubuntu, either libcrypto or aws-sdk-cpp has a memory leak. |
||
|---|---|---|
| .. | ||
| bad_cdf5_begin.nc | ||
| CMakeLists.txt | ||
| error.c | ||
| error.h | ||
| f03tst_open_mem.nc | ||
| large_files.c | ||
| make_test_file.sh | ||
| Makefile.am | ||
| nc_enddef.cdl | ||
| nc_sync.cdl | ||
| nc_test.c | ||
| nc_test.html | ||
| quick_large_files.c | ||
| ref_tst_diskless2.cdl | ||
| ref_tst_diskless3_create.cdl | ||
| ref_tst_diskless3_open.cdl | ||
| ref_tst_http_nc3.cdl | ||
| ref_tst_http_nc4a.cdl | ||
| ref_tst_http_nc4b.cdl | ||
| ref_tst_http_nc4c.cdl | ||
| ref_tst_http_nc4e.cdl | ||
| ref_tst_http_nc4f.cdl | ||
| run_cdf5.sh | ||
| run_diskless2.sh | ||
| run_diskless5.sh | ||
| run_diskless.sh | ||
| run_inmemory.sh | ||
| run_mmap.sh | ||
| run_pnetcdf_tests.sh.in | ||
| t_nc_p5.c | ||
| t_nc.c | ||
| test_byterange.sh | ||
| test_get.m4 | ||
| test_put.m4 | ||
| test_read.m4 | ||
| test_write.m4 | ||
| testnc3perf.c | ||
| tests.h | ||
| tst_addvar.c | ||
| tst_atts3.c | ||
| tst_big_rvar.c | ||
| tst_big_var2.c | ||
| tst_big_var6.c | ||
| tst_big_var.c | ||
| tst_byterange.c | ||
| tst_cdf5_begin.c | ||
| tst_cdf5format.c | ||
| tst_def_var_fill.c | ||
| tst_default_format_pnetcdf.c | ||
| tst_default_format.c | ||
| tst_diskless2.c | ||
| tst_diskless3.c | ||
| tst_diskless4.c | ||
| tst_diskless5.c | ||
| tst_diskless5.cdl | ||
| tst_diskless6.c | ||
| tst_diskless.c | ||
| tst_err_enddef.c | ||
| tst_formats.c | ||
| tst_formatx_pnetcdf.c | ||
| tst_global_fillval.c | ||
| tst_inmemory.c | ||
| tst_inq_type.c | ||
| tst_large_cdf5.c | ||
| tst_large.c | ||
| tst_max_var_dims.c | ||
| tst_meta.c | ||
| tst_misc.c | ||
| tst_names.c | ||
| tst_nofill2.c | ||
| tst_nofill3.c | ||
| tst_nofill.c | ||
| tst_norm.c | ||
| tst_open_cdf5.c | ||
| tst_open_mem.c | ||
| tst_parallel2.c | ||
| tst_pnetcdf.c | ||
| tst_small.c | ||
| tst_utf8_phrases.c | ||
| tst_utf8_validate.c | ||
| util.c | ||