mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2024-12-21 08:39:46 +08:00
Code Issues Packages Projects Releases Wiki Activity
2f103420f6
netcdf-c/libhdf5
History
Dennis Heimbigner 69e84fe9f1 Fix byterange handling of some URLS 
re: Issue

The byterange handling of the following URLS fails.

### Problem 1: "https://crudata.uea.ac.uk/cru/data/temperature/HadCRUT.4.6.0.0.median.nc#mode=bytes"
It turns out that byterange in hdf5 has two possible targets: S3 and not-S3 (e.g. a thredds server or the crudata URL above). Each uses a different HDF5 Virtual File Driver (VFD).
I incorrectly set up the byterange code in libhdf5 so that it would choose one or the other of the two VFD's for any netcdf-c library build. The fix is to allow it to choose either one at run-time.

### Problem 2: "https://noaa-goes16.s3.amazonaws.com/ABI-L1b-RadF/2022/001/18/OR_ABI-L1b-RadF-M6C01_G16_s20220011800205_e20220011809513_c20220011809562.nc#mode=bytes,s3"
When given what appears to be an S3-related URL, the netcdf-c library code converts it into a canonical, so-called "path" format. In casing out the possible input URL formats, I missed the case where the host contains the bucket ("noaa-goes16"), but not the region. So the fix was to check for this case.

## Misc. Related Changes
1. Since S3 is used in more than just NCZarr, I changed the automake/cmake options to replace "--enable-nczarr-s3" with "--enable-s3", but keeping the former option as a synonym for the latter. This also entailed cleaning up libnetcdf.settings WRT S3 support
2. Added the above URLS as additional test cases

## Misc. Un-Related Changes
1. CURLOPT_PUT is deprecated in favor to CURLOPT_UPLOAD
2. Fix some minor warnings

## Open Problems
* Under Ubuntu, either libcrypto or aws-sdk-cpp has a memory leak.
2023-03-02 19:51:02 -07:00
..
CMakeLists.txt Format compatibility when re-opening files 2022-01-07 18:34:52 -07:00
H5FDhttp.c Modify H5FDhttp.c to work with HDF5 1.14.0 2023-02-10 15:10:43 -07:00
H5FDhttp.h Fix byterange handling of some URLS 2023-03-02 19:51:02 -07:00
hdf5attr.c Fix various problem around VLEN's 2022-01-08 18:30:00 -07:00
hdf5create.c Merge branch 'dimscale_attachement_optional' of https://github.com/gsjaardema/netcdf-c into gh2161.wif 2022-04-19 11:06:34 -06:00
hdf5debug.c Fix byterange handling of some URLS 2023-03-02 19:51:02 -07:00
hdf5debug.h Support MSYS2/Mingw platform 2021-12-23 22:18:56 -07:00
hdf5dim.c fixing issues with dimlens of unlitmited dims in complex situations 2022-05-29 15:22:10 +03:00
hdf5dispatch.c Enhance/Fix filter support 2022-03-14 12:39:37 -06:00
hdf5err.h
hdf5file.c code and documentation cleanup 2022-07-02 07:51:33 -06:00
hdf5filter.c Enhance/Fix filter support 2022-03-14 12:39:37 -06:00
hdf5grp.c
hdf5internal.c fixing parallel I/O bug with dim length for unlimited dimensions 2022-04-26 07:54:47 -06:00
hdf5open.c Fix byterange handling of some URLS 2023-03-02 19:51:02 -07:00
hdf5set_format_compatibility.c hdf5set_format_compatibility.c: Function docs. 2022-02-01 09:58:36 -07:00
hdf5type.c Fix various problem around VLEN's 2022-01-08 18:30:00 -07:00
hdf5var.c Fix support for reading arrays of HDF5 fixed size strings 2022-07-29 14:47:07 -06:00
Makefile.am Format compatibility when re-opening files 2022-01-07 18:34:52 -07:00
nc4hdf.c code and documentation cleanup 2022-07-02 08:13:13 -06:00
nc4info.c
nc4mem.c
nc4memcb.c