mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-21 03:13:42 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
66 lines
1.7 KiB
C
66 lines
1.7 KiB
C
#ifndef NCGEN_DEBUG_H
|
|
#define NCGEN_DEBUG_H
|
|
|
|
/*********************************************************************
|
|
* Copyright 1993, UCAR/Unidata
|
|
* See netcdf/COPYRIGHT file for copying and redistribution conditions.
|
|
* $Header: /upc/share/CVS/netcdf-3/ncgen/debug.h,v 1.2 2010/03/31 18:18:34 dmh Exp $
|
|
*********************************************************************/
|
|
|
|
#include <stdarg.h>
|
|
#include <assert.h>
|
|
#include "generr.h"
|
|
#include "bytebuffer.h"
|
|
|
|
#if 0
|
|
#define GENDEBUG 2
|
|
#endif
|
|
|
|
#ifdef GENDEBUG
|
|
# if GENDEBUG > 0
|
|
# define GENDEBUG1
|
|
# endif
|
|
# if GENDEBUG > 1
|
|
# define GENDEBUG2
|
|
# endif
|
|
# if GENDEBUG > 2
|
|
# define GENDEBUG3
|
|
# endif
|
|
#endif
|
|
|
|
extern int settrace(int);
|
|
|
|
extern int debug;
|
|
extern int ncgdebug;
|
|
|
|
extern void fdebug(const char *fmt, ...);
|
|
|
|
#define PANIC(msg) assert(panic(msg))
|
|
#define PANIC1(msg,arg) assert(panic(msg,arg))
|
|
#define PANIC2(msg,arg1,arg2) assert(panic(msg,arg1,arg2))
|
|
#define ASSERT(expr) {if(!(expr)) {panic("assertion failure: %s",#expr);}}
|
|
extern int panic(const char* fmt, ...);
|
|
|
|
/*
|
|
Provide wrapped versions of XXXalloc for debugging/
|
|
The wrapped version:
|
|
1. fails if size is zero or memory is NULL
|
|
2. fails if memory is exhausted.
|
|
3. zeros all allocated memory.
|
|
*/
|
|
|
|
#define emalloc(x) chkmalloc(x) /*note only single arg */
|
|
#define ecalloc(x) chkcalloc(x) /*note only single arg */
|
|
#define erealloc(p,x) chkrealloc(p,x)
|
|
#define efree(x) chkfree(x)
|
|
#define estrdup(x) chkstrdup(x)
|
|
extern void* chkmalloc(size_t);
|
|
extern void* chkcalloc(size_t);
|
|
extern void* chkrealloc(void*,size_t);
|
|
extern void chkfree(void*);
|
|
extern char* chkstrdup(const char* s);
|
|
|
|
#define MEMCHECK(var,throw) {if((var)==NULL) return (throw);}
|
|
|
|
#endif /*NCGEN_DEBUG_H*/
|