mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-21 03:13:42 +08:00
245961de00
https://github.com/Unidata/netcdf-c/issues/1168 https://github.com/Unidata/netcdf-c/issues/1163 https://github.com/Unidata/netcdf-c/issues/1162 This PR partially fixes memory leaks in the netcdf-c library, in the ncdump utility, and in some test cases. The netcdf-c library now runs memory clean with the assumption that the --disable-utilities option is used. The primary remaining problem is ncgen. Once that is fixed, I believe the netcdf-c library will run memory clean with no limitations. Notes ----------- 1. Memory checking was performed using gcc -fsanitize=address. Valgrind-based testing has yet to be performed. 2. The pnetcdf, hdf4, and examples code has not been tested. Misc. Non-leak changes 1. Make tst_diskless2 only run when netcdf4 is enabled (issue 1162) 2. Fix CmakeLists.txt to turn off logging if ENABLE_NETCDF_4 is OFF 3. Isolated all my debug scripts into a single top-level directory called debug 4. Fix some USE_NETCDF4 dependencies in nc_test and nc_test4 Makefile.am
259 lines
5.1 KiB
C
259 lines
5.1 KiB
C
/* Copyright 2009, UCAR/Unidata and OPeNDAP, Inc.
|
|
See the COPYRIGHT file for more information. */
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
|
|
#include "nclist.h"
|
|
|
|
int nclistnull(void* e) {return e == NULL;}
|
|
|
|
#ifndef TRUE
|
|
#define TRUE 1
|
|
#endif
|
|
#ifndef FALSE
|
|
#define FALSE 0
|
|
#endif
|
|
|
|
#define DEFAULTALLOC 16
|
|
#define ALLOCINCR 16
|
|
|
|
NClist* nclistnew(void)
|
|
{
|
|
NClist* l;
|
|
/*
|
|
if(!ncinitialized) {
|
|
memset((void*)&ncDATANULL,0,sizeof(void*));
|
|
ncinitialized = 1;
|
|
}
|
|
*/
|
|
l = (NClist*)malloc(sizeof(NClist));
|
|
if(l) {
|
|
l->alloc=0;
|
|
l->length=0;
|
|
l->content=NULL;
|
|
}
|
|
return l;
|
|
}
|
|
|
|
int
|
|
nclistfree(NClist* l)
|
|
{
|
|
if(l) {
|
|
l->alloc = 0;
|
|
if(l->content != NULL) {free(l->content); l->content = NULL;}
|
|
free(l);
|
|
}
|
|
return TRUE;
|
|
}
|
|
|
|
/*
|
|
Free a list and its contents
|
|
*/
|
|
int
|
|
nclistfreeall(NClist* l)
|
|
{
|
|
size_t i,len;
|
|
void** content = NULL;
|
|
if(l == NULL) return TRUE;
|
|
len = l->length;
|
|
content = nclistextract(l);
|
|
for(i=0;i<len;i++) {
|
|
void* value = content[i];
|
|
if(value != NULL) free(value);
|
|
}
|
|
if(content != NULL) free(content);
|
|
return nclistfree(l);
|
|
}
|
|
|
|
int
|
|
nclistsetalloc(NClist* l, size_t sz)
|
|
{
|
|
void** newcontent = NULL;
|
|
if(l == NULL) return FALSE;
|
|
if(sz <= 0) {sz = (l->length?2*l->length:DEFAULTALLOC);}
|
|
if(l->alloc >= sz) {return TRUE;}
|
|
newcontent=(void**)calloc(sz,sizeof(void*));
|
|
if(newcontent != NULL && l->alloc > 0 && l->length > 0 && l->content != NULL) {
|
|
memcpy((void*)newcontent,(void*)l->content,sizeof(void*)*l->length);
|
|
}
|
|
if(l->content != NULL) free(l->content);
|
|
l->content=newcontent;
|
|
l->alloc=sz;
|
|
return TRUE;
|
|
}
|
|
|
|
int
|
|
nclistsetlength(NClist* l, size_t newlen)
|
|
{
|
|
if(l == NULL) return FALSE;
|
|
if(newlen > l->alloc && !nclistsetalloc(l,newlen)) return FALSE;
|
|
if(newlen > l->length) {
|
|
/* clear any extension */
|
|
memset(&l->content[l->length],0,(newlen - l->length)*sizeof(void*));
|
|
}
|
|
l->length = newlen;
|
|
return TRUE;
|
|
}
|
|
|
|
void*
|
|
nclistget(NClist* l, size_t index)
|
|
{
|
|
if(l == NULL || l->length == 0) return NULL;
|
|
if(index >= l->length) return NULL;
|
|
return l->content[index];
|
|
}
|
|
|
|
/* Insert at position i of l; will overwrite previous value;
|
|
guarantees alloc and length
|
|
*/
|
|
int
|
|
nclistset(NClist* l, size_t index, void* elem)
|
|
{
|
|
if(l == NULL) return FALSE;
|
|
if(!nclistsetalloc(l,index+1)) return FALSE;
|
|
if(index >= l->length) {
|
|
if(!nclistsetlength(l,index+1)) return FALSE;
|
|
}
|
|
l->content[index] = elem;
|
|
return TRUE;
|
|
}
|
|
|
|
/* Insert at position i of l; will push up elements i..|seq|. */
|
|
int
|
|
nclistinsert(NClist* l, size_t index, void* elem)
|
|
{
|
|
long i; /* do not make unsigned */
|
|
if(l == NULL) return FALSE;
|
|
if(index > l->length) return FALSE;
|
|
nclistsetalloc(l,0);
|
|
for(i=(long)l->length;i>index;i--) l->content[i] = l->content[i-1];
|
|
l->content[index] = elem;
|
|
l->length++;
|
|
return TRUE;
|
|
}
|
|
|
|
int
|
|
nclistpush(NClist* l, void* elem)
|
|
{
|
|
if(l == NULL) return FALSE;
|
|
if(l->length >= l->alloc) nclistsetalloc(l,0);
|
|
l->content[l->length] = elem;
|
|
l->length++;
|
|
return TRUE;
|
|
}
|
|
|
|
void*
|
|
nclistpop(NClist* l)
|
|
{
|
|
if(l == NULL || l->length == 0) return NULL;
|
|
l->length--;
|
|
return l->content[l->length];
|
|
}
|
|
|
|
void*
|
|
nclisttop(NClist* l)
|
|
{
|
|
if(l == NULL || l->length == 0) return NULL;
|
|
return l->content[l->length - 1];
|
|
}
|
|
|
|
void*
|
|
nclistremove(NClist* l, size_t i)
|
|
{
|
|
size_t len;
|
|
void* elem;
|
|
if(l == NULL || (len=l->length) == 0) return NULL;
|
|
if(i >= len) return NULL;
|
|
elem = l->content[i];
|
|
for(i+=1;i<len;i++) l->content[i-1] = l->content[i];
|
|
l->length--;
|
|
return elem;
|
|
}
|
|
|
|
/* Duplicate and return the content (null terminate) */
|
|
void**
|
|
nclistdup(NClist* l)
|
|
{
|
|
void** result = (void**)malloc(sizeof(void*)*(l->length+1));
|
|
memcpy((void*)result,(void*)l->content,sizeof(void*)*l->length);
|
|
result[l->length] = (void*)0;
|
|
return result;
|
|
}
|
|
|
|
int
|
|
nclistcontains(NClist* l, void* elem)
|
|
{
|
|
size_t i;
|
|
for(i=0;i<nclistlength(l);i++) {
|
|
if(elem == nclistget(l,i)) return 1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/* Remove element by value; only removes first encountered */
|
|
int
|
|
nclistelemremove(NClist* l, void* elem)
|
|
{
|
|
size_t len;
|
|
size_t i;
|
|
int found = 0;
|
|
if(l == NULL || (len=l->length) == 0) return 0;
|
|
for(i=0;i<nclistlength(l);i++) {
|
|
void* candidate = l->content[i];
|
|
if(elem == candidate) {
|
|
for(i+=1;i<len;i++) l->content[i-1] = l->content[i];
|
|
l->length--;
|
|
found = 1;
|
|
break;
|
|
}
|
|
}
|
|
return found;
|
|
}
|
|
|
|
|
|
/* Extends nclist to include a unique operator
|
|
which remove duplicate values; NULL values removed
|
|
return value is always 1.
|
|
*/
|
|
|
|
int
|
|
nclistunique(NClist* l)
|
|
{
|
|
size_t i,j,k,len;
|
|
void** content;
|
|
if(l == NULL || l->length == 0) return 1;
|
|
len = l->length;
|
|
content = l->content;
|
|
for(i=0;i<len;i++) {
|
|
for(j=i+1;j<len;j++) {
|
|
if(content[i] == content[j]) {
|
|
/* compress out jth element */
|
|
for(k=j+1;k<len;k++) content[k-1] = content[k];
|
|
len--;
|
|
}
|
|
}
|
|
}
|
|
l->length = len;
|
|
return 1;
|
|
}
|
|
|
|
NClist*
|
|
nclistclone(NClist* l)
|
|
{
|
|
NClist* clone = nclistnew();
|
|
*clone = *l;
|
|
clone->content = nclistdup(l);
|
|
return clone;
|
|
}
|
|
|
|
void*
|
|
nclistextract(NClist* l)
|
|
{
|
|
void* result = l->content;
|
|
l->alloc = 0;
|
|
l->length = 0;
|
|
l->content = NULL;
|
|
return result;
|
|
}
|