mirror of
https://github.com/Unidata/netcdf-c.git
synced 2024-11-27 07:30:33 +08:00
751300ec59
This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173 Sorry that it is so big, but leak suppression can be complex. This PR fixes all remaining memory leaks -- as determined by -fsanitize=address, and with the exceptions noted below. Unfortunately. there remains a significant leak that I cannot solve. It involves vlens, and it is unclear if the leak is occurring in the netcdf-c library or the HDF5 library. I have added a check_PROGRAM to the ncdump directory to show the problem. The program is called tst_vlen_demo.c To exercise it, build the netcdf library with -fsanitize=address enabled. Then go into ncdump and do a "make clean check". This should build tst_vlen_demo without actually executing it. Then do the command "./tst_vlen_demo" to see the output of the memory checker. Note the the lost malloc is deep in the HDF5 library (in H5Tvlen.c). I am temporarily working around this error in the following way. 1. I modified several test scripts to not execute known vlen tests that fail as described above. 2. Added an environment variable called NC_VLEN_NOTEST. If set, then those specific tests are suppressed. This should mean that the --disable-utilities option to ./configure should not need to be set to get a memory leak clean build. This should allow for detection of any new leaks. Note: I used an environment variable rather than a ./configure option to control the vlen tests. This is because it is temporary (I hope) and because it is a bit tricky for shell scripts to access ./configure options. Finally, as before, this only been tested with netcdf-4 and hdf5 support.
139 lines
3.1 KiB
C
139 lines
3.1 KiB
C
/*********************************************************************
|
|
* Copyright 2009, UCAR/Unidata
|
|
* See netcdf/COPYRIGHT file for copying and redistribution conditions.
|
|
*********************************************************************/
|
|
|
|
#include "includes.h"
|
|
#include "nc_iter.h"
|
|
|
|
#ifdef ENABLE_F77
|
|
|
|
#include <math.h>
|
|
|
|
int f77_uid = 0;
|
|
|
|
static int
|
|
f77_charconstant(Generator* generator, Symbol* sym, Bytebuffer* codebuf, ...)
|
|
{
|
|
/* Escapes and quoting will be handled in genc_write */
|
|
/* Just transfer charbuf to codebuf */
|
|
Bytebuffer* charbuf;
|
|
va_list ap;
|
|
va_start(ap,codebuf);
|
|
charbuf = va_arg(ap, Bytebuffer*);
|
|
va_end(ap);
|
|
bbNull(charbuf);
|
|
bbCatbuf(codebuf,charbuf);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_constant(Generator* generator, Symbol* sym, NCConstant* ci, Bytebuffer* codebuf,...)
|
|
{
|
|
char tmp[64];
|
|
char* special = NULL;
|
|
switch (ci->nctype) {
|
|
|
|
case NC_CHAR:
|
|
if(ci->value.charv == '\'')
|
|
sprintf(tmp,"'\\''");
|
|
else
|
|
sprintf(tmp,"'%c'",ci->value.charv);
|
|
break;
|
|
case NC_BYTE:
|
|
sprintf(tmp,"%hhd",ci->value.int8v);
|
|
break;
|
|
case NC_SHORT:
|
|
sprintf(tmp,"%hd",ci->value.int16v);
|
|
break;
|
|
case NC_INT:
|
|
sprintf(tmp,"%d",ci->value.int32v);
|
|
break;
|
|
case NC_FLOAT:
|
|
sprintf(tmp,"%.8g",ci->value.floatv);
|
|
break;
|
|
case NC_DOUBLE: {
|
|
char* p = tmp;
|
|
/* FORTRAN requires e|E->D */
|
|
sprintf(tmp,"%.16g",ci->value.doublev);
|
|
while(*p) {if(*p == 'e' || *p == 'E') {*p = 'D';}; p++;}
|
|
} break;
|
|
case NC_STRING:
|
|
{
|
|
Bytebuffer* buf = bbNew();
|
|
bbAppendn(buf,ci->value.stringv.stringv,ci->value.stringv.len);
|
|
f77quotestring(buf);
|
|
special = bbDup(buf);
|
|
bbFree(buf);
|
|
}
|
|
break;
|
|
|
|
default: PANIC1("f77data: bad type code: %d",ci->nctype);
|
|
|
|
}
|
|
if(special != NULL)
|
|
bbCat(codebuf,special);
|
|
else
|
|
bbCat(codebuf,tmp);
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_listbegin(Generator* generator, Symbol* sym, void* liststate, ListClass lc, size_t size, Bytebuffer* codebuf, int* uidp, ...)
|
|
{
|
|
if(uidp) *uidp = ++f77_uid;
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_list(Generator* generator, Symbol* sym, void* liststate, ListClass lc, int uid, size_t count, Bytebuffer* codebuf, ...)
|
|
{
|
|
switch (lc) {
|
|
case LISTATTR:
|
|
if(count > 0) bbCat(codebuf,", ");
|
|
break;
|
|
case LISTDATA:
|
|
bbAppend(codebuf,' ');
|
|
break;
|
|
case LISTVLEN:
|
|
case LISTCOMPOUND:
|
|
case LISTFIELDARRAY:
|
|
break;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_listend(Generator* generator, Symbol* sym, void* liststate, ListClass lc, int uid, size_t count, Bytebuffer* buf, ...)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_vlendecl(Generator* generator, Symbol* tsym, Bytebuffer* codebuf, int uid, size_t count, ...)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
f77_vlenstring(Generator* generator, Symbol* sym, Bytebuffer* vlenmem, int* uidp, size_t* countp,...)
|
|
{
|
|
if(uidp) *uidp = ++f77_uid;
|
|
return 1;
|
|
}
|
|
|
|
/* Define the single static bin data generator */
|
|
static Generator f77_generator_singleton = {
|
|
NULL,
|
|
f77_charconstant,
|
|
f77_constant,
|
|
f77_listbegin,
|
|
f77_list,
|
|
f77_listend,
|
|
f77_vlendecl,
|
|
f77_vlenstring
|
|
};
|
|
Generator* f77_generator = &f77_generator_singleton;
|
|
|
|
#endif /*ENABLE_F77*/
|