Commit Graph

6410 Commits

Author SHA1 Message Date
Ward Fisher
e9aeafe0fd
Merge branch 'master' into ejh_more_rename_woes_3 2019-02-13 16:37:28 -07:00
Ward Fisher
4a06f24813
Merge branch 'master' into ejh_more_rename_woes_2 2019-02-13 16:35:54 -07:00
Ward Fisher
6c3b7a0077
Merge branch 'master' into urlauth.dmh 2019-02-13 16:32:38 -07:00
Ward Fisher
29d2643f8e
Merge pull request #1317 from Unidata/fillhack.dmh
Add hack to deal with DAP2 signed byte conversion.
2019-02-13 16:07:19 -07:00
Dennis Heimbigner
724128ad3b Add hack to deal with DAP2 signed byte hack.
re: issue https://github.com/Unidata/netcdf-c/issues/1316

The DAP2 data model does not have a signed byte type,
but netcdf-3 does have (only) a signed byte type.
So, when converting a netcdf-3 signed byte typed variable to
a DAP2 unsigned byte, the following actions are taken by thredds:
1. The variable type is marked as DAP2 (unsigned) byte.
2. A special attribute, "_Unsigned=false" is set for the variable
3. The corresponding "_FillValue" attribute, if any, is up-converted
   to the DAP2 Int16 type in order to hold, with sign, any signed byte
   fill value.

On the netcdf-c side, this looks like a fillvalue type mismatch and causes
an error. Instead, the netcdf-c dap2 conversion code needs to recognize
this hack and undo it locally.

So this change looks for the above case, and if found, then it properly
converts the _FillValue type to netcdf-3 signed byte.

Since DAP2 supports both signed and unsigned integers of sizes 16 and 32 bits,
this should be the only hack needed (famous last words).

It may later be desirable for the thredds DAP2 converter to modify its
behavior as well.
2019-02-13 14:36:14 -07:00
Ed Hartnett
f937ed7b25
Merge branch 'master' into ejh_more_rename_woes_2 2019-02-12 15:05:34 -07:00
Ward Fisher
e32e0b1eb2
Merge branch 'master' into filterexpr.dmh 2019-02-12 09:48:03 -07:00
Ward Fisher
ec06e9d4c9
Merge branch 'master' into ejh_more_rename_woes_3 2019-02-12 09:47:34 -07:00
Ward Fisher
bbe19501d1
Merge pull request #1314 from simonholgate/fix_tst_cdf5format_for_loop
Added int i and j declarations
2019-02-12 09:41:05 -07:00
Simon Holgate
6834f4155c Added int i and j declarations 2019-02-12 15:10:39 +00:00
Ed Hartnett
909402ccd6
Merge branch 'master' into ejh_more_rename_woes_3 2019-02-12 05:49:04 -07:00
Ed Hartnett
1c22629201
Merge branch 'master' into ejh_more_rename_woes_2 2019-02-12 05:48:45 -07:00
Ward Fisher
56f94893ec
Merge pull request #1302 from Unidata/bigend.dmh
Fix errors when building on big-endian machine
2019-02-11 16:38:55 -07:00
Dennis Heimbigner
5f0fdd7e5d Update Makefile.am to use ref_ filter files 2019-02-11 16:07:03 -07:00
Ward Fisher
adf4a48a29 Corrected a doxygen warning in the DAP4 documentation. 2019-02-11 13:29:40 -07:00
Ward Fisher
40f2f5e949 Updated link to reflect newer netCDF-Fortran documentation location. 2019-02-11 13:28:34 -07:00
Ward Fisher
70bd755548 Fixed typo. 2019-02-11 13:06:41 -07:00
Ward Fisher
ebf507233c Updated link to new fortran documentation. 2019-02-11 13:03:07 -07:00
Dennis Heimbigner
8d59f4ebb8 Add missing updates from bigend.tmp 2019-02-10 14:00:40 -07:00
Dennis Heimbigner
e932655888 Renamed the baseline files for tst_filter.sh 2019-02-09 15:14:13 -07:00
Dennis Heimbigner
4cd440dd96 URL with username+pwd in url is not working.
re: esupport (DVK-211460)

Turns out it was a typo in libdispatch/dauth.c
Fix is to Change:
HTTP.USERNAME -> HTTP.CREDENTIALS.USERNAME
and
HTTP.PASSWORD-> HTTP.CREDENTIALS.PASSWORD
2019-02-09 15:06:03 -07:00
Dennis Heimbigner
a6b04c0c66 Extend nccopy -F option syntax.
A user suggested that the nccopy -F option
syntax should be extended to support specification
of multiple (or all) variables in a single -F option.

The new syntax allows:

1. '*' as the name of the variable; this means apply the
   filter to all variables in the data set.
2. *var1|var2|...* as the variable name to indicate that the filter
   should be applied to the multiple specified variables.
2019-02-08 18:48:17 -07:00
Ward Fisher
4c6d56abc0
Merge branch 'master' into ejh_more_rename_woes_3 2019-02-07 14:28:46 -07:00
Ward Fisher
1d56285145
Merge branch 'master' into ejh_more_rename_woes_2 2019-02-07 14:28:43 -07:00
Ward Fisher
3a14251dd9
Merge branch 'master' into bigend.dmh 2019-02-07 14:28:39 -07:00
Ward Fisher
a260bbbf76
Merge pull request #1309 from Unidata/pr-aggregation.wif
Rinse and Repeat: PR Edition
2019-02-07 14:27:17 -07:00
Ward Fisher
6511599a6d Corrected issue in support of https://github.com/Unidata/netcdf-c/issues/1310 2019-02-07 12:43:07 -07:00
Ward Fisher
035b3030ef Merge branch 'ejh_rename_var_to_non_coord_var' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into pr-aggregation.wif 2019-02-06 14:09:48 -07:00
Ward Fisher
ecc11ed29d Merge remote-tracking branch 'origin/gh1295.wif' into pr-aggregation.wif 2019-02-06 14:09:00 -07:00
Ward Fisher
9aae0351ac Merge branch 'ejh_rename_bug' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into pr-aggregation.wif 2019-02-06 14:08:41 -07:00
Ward Fisher
2c335466bd Merge branch 'ejh_not_read_rename_2' of https://github.com/NetCDF-World-Domination-Council/netcdf-c into pr-aggregation.wif 2019-02-06 14:08:06 -07:00
Ward Fisher
67086ccd66 Merge branch 'fix-warnings' of https://github.com/mathstuf/netcdf-c into pr-aggregation.wif 2019-02-06 14:07:29 -07:00
Ward Fisher
5fca0edf73 Move away from deprecated PackageManager to the productbuild generator. 2019-02-05 13:08:30 -07:00
Ward Fisher
455bf13529 Some housekeeping. Next big push may be to clean up older files. 2019-02-05 12:57:27 -07:00
Ed Hartnett
70201adb51 comment cleanup 2019-02-03 07:43:56 -07:00
Ed Hartnett
5d908a0bbb now preserve order of varids after a var rename 2019-02-03 06:56:03 -07:00
Ed Hartnett
8e6f38b099 detecting conditions for mandatory rename of vars with varid > renamed var 2019-02-03 06:35:29 -07:00
Ed Hartnett
275e116f49 added test to demonstrate out of order varids after rename 2019-02-03 06:28:04 -07:00
Ed Hartnett
cb47eaf895 uncommented some testing 2019-02-02 07:43:56 -07:00
Ed Hartnett
e30a2bf208 added come comments 2019-02-02 07:32:31 -07:00
Ed Hartnett
8acde75e3c converted hdf5gtp.c to use H5Lmove instead of deprecated H5Gmove 2019-02-02 07:24:02 -07:00
Ed Hartnett
f25f050be8 converted hdf5var to use H5Lmove instead of deprecated H5Gmove 2019-02-02 07:20:14 -07:00
Ed Hartnett
aed2a4c1db got tst_h_rename using H5Lmove 2019-02-02 07:17:57 -07:00
Ed Hartnett
373c0b5665 added tst_h_rename.c to check HDF5 renaming behavior 2019-02-02 06:17:43 -07:00
Ed Hartnett
6728fceab6 uncommented a bunch of rename tests 2019-02-02 05:55:18 -07:00
Ed Hartnett
1dd76c996e added tst_rename3.c for more rename testing 2019-02-02 05:53:45 -07:00
Ed Hartnett
c8cbff4728 added test (commented out) in tst_rename2.c which fails 2019-02-02 04:00:34 -07:00
Dennis Heimbigner
8714066b18 Fix errors when building on big-endian machine
re: issue https://github.com/Unidata/netcdf-c/issues/1278
re: issue https://github.com/Unidata/netcdf-c/issues/876
re: issue https://github.com/Unidata/netcdf-c/issues/806

* Major change to the handling of 8-byte parameters for nc_def_var_filter.
  The old code was not well thought out.
  * The new algorithm is documented in docs/filters.md.
  * Added new utility file plugins/H5Zutil.c to support
  * Modified plugins/H5Zmisc.c to use new algorithm
  the new algorithm.
  * Renamed include/ncfilter.h to include/netcdf_filter.h
    and made it an installed header so clients can access the
    new algorithm utility.
  * Fixed nc_test4/tst_filterparser.c and nc_test4/test_filter_misc.c
    to use the new algorithm
* libdap4/ fixes:
  * d4swap.c has an error in the endian pre-processing such
    that record counts were not being swapped correctly.
  * d4data.c had an error in that checksums were being computed
    after endian swapping rather than before.
* ocinitialize() was never being called, so xxdr bigendian handling
  was never set correctly.
  * Required adding debug statements to occompile
* Found and fixed memory leak in ncdump.c

Not tested:
* HDF4
* Pnetcdf
* parallel HDF5
2019-01-31 21:13:06 -07:00
Ward Fisher
9ca942b201
Merge branch 'master' into fix-warnings 2019-01-31 12:39:06 -07:00
Ed Hartnett
9cde4f0185
Merge branch 'master' into ejh_rename_bug 2019-01-30 12:17:37 -07:00