Commit Graph

8092 Commits

Author SHA1 Message Date
Dennis Heimbigner
8be7d29335 Turn off bad test 2021-08-11 14:59:27 -06:00
Dennis Heimbigner
a58d243245 Fix library crash 2021-08-11 12:28:06 -06:00
Dennis Heimbigner
2a0fdb34d7 Fix RELEASE_NOTES conflicts 2021-08-10 15:02:38 -06:00
Dennis Heimbigner
aeeeb11e1e de-push 2021-08-10 14:53:52 -06:00
Dennis Heimbigner
3b13943e4d Add test cases 2021-08-10 14:15:24 -06:00
Ward Fisher
a193b444eb
Merge pull request #2065 from DennisHeimbigner/netpath.dmh
Support Windows network paths: \\svc\x\y...
2021-08-10 11:12:36 -06:00
Ward Fisher
0b5b484734
Merge pull request #2042 from mathstuf/nc3-support
dinfermodel: don't fail if NC_NETCDF4 is allowed, but NC3 is found
2021-08-10 11:11:22 -06:00
Ben Boeckel
f7a52e7fbd dinfermodel: don't fail if NC_NETCDF4 is allowed, but NC3 is found
In VTK, there are some files which require the NC3 implementation, but
no longer open under 4.8.0 (it worked under 4.7.4). The code checks to
make sure that certain formats were *not* requested when it is entirely
reasonable that support may be required for other files.

This partially reverts changes made in
59e04ae071 which is a massive commit which
adds Zarr support but doesn't mention why this specific change was made.
2021-08-10 07:40:29 -04:00
Dennis Heimbigner
42854d19de update release notes 2021-08-09 17:09:18 -06:00
Dennis Heimbigner
ec258bf314 Fix a number of bugs in the nczarr code.
re: Issues https://github.com/Unidata/netcdf-c/issues/2063, https://github.com/Unidata/netcdf-c/issues/2062, https://github.com/Unidata/netcdf-c/issues/2061, https://github.com/Unidata/netcdf-c/issues/2059

1. Support "fill_value: null" (https://github.com/Unidata/netcdf-c/issues/2063).
2. Handle the dtype case "|u1" (https://github.com/Unidata/netcdf-c/issues/2062).
3. When writing a pure Zarr format file, some nczarr attributes inadvertently crept in (https://github.com/Unidata/netcdf-c/issues/2061).
4. If there is no fill value, then the .zarray fill_value key should have the value null rather than left out (https://github.com/Unidata/netcdf-c/issues/2059).

Hat tip: Even Rouault
2021-08-09 17:05:02 -06:00
Ward Fisher
07b1464237
Merge pull request #2064 from edwardhartnett/ejh_mem1
Turn off tst_mem1.c test as part of benchmarks
2021-08-09 15:42:59 -06:00
Dennis Heimbigner
01487ecbf1 Update release notes 2021-08-09 15:37:42 -06:00
Dennis Heimbigner
de23473ac3 Support Windows network paths: \\svc\x\y...
re: Issue https:\\github.com\Unidata\netcdf-c\issues\2060

The path conversion code forgot to consider the case of
windows network paths of the form \\svc\x\y...

I have added support for it, but I can't really test it
since I do not have access to a network drive.
2021-08-09 15:34:23 -06:00
Edward Hartnett
78cc4743fa merged ejh_fix_warning 2021-08-09 13:46:10 -06:00
Edward Hartnett
b832ee3ad9 remove nc_perf/tst_mem1 from tests run 2021-08-09 13:43:17 -06:00
Edward Hartnett
3955376af6 remove nc_perf/tst_mem1 from tests run 2021-08-09 13:42:04 -06:00
Ward Fisher
a68d671686
Merge pull request #2058 from DennisHeimbigner/bmfix.dmh
Add missing files so --enable-benchmarks works again.
2021-08-09 11:54:41 -06:00
Dennis Heimbigner
e923d3965f Add missing files so --enable-benchmarks works again.
re: https://github.com/Unidata/netcdf-c/issues/2055

The nczarr_test benchmarks were missing some files and one was
out of date vis-a-vis compilation.
2021-08-07 21:19:40 -06:00
Ward Fisher
70862eb435
Merge pull request #2052 from e4t/build-fixes
check: Include testpathcvt.sh only if test is built
2021-08-05 10:14:16 -06:00
Greg Sjaardema
c3f20c88e9
Make variable easier to compress
Make the data in the variable `var1` easier to compress so that the compression tests will be more robust.  The zlib_ng library, for example, at level 1 does not compress a sequence of integers very well which resulted in the NetCDF-4 compressed file being larger than the uncompressed NetCDF-3 file.  With the change above, the variable contains `0,0,0,1,1,1,2,2,2,...,` which compresses at level 1 and the compression test is more robust.
2021-08-05 07:52:50 -06:00
Egbert Eich
6c4cb2c9f3 check: Include testpathcvt.sh only if test is built
This avoids the test case to fail if it isn't.

Signed-off-by: Egbert Eich <eich@suse.com>
2021-08-04 18:37:23 +02:00
Greg Sjaardema
b9d192d0c4
Only write the coord dimids if ndims >= 1
It looks like some vars have ndims==0 in which case the coord_dimids should not be written. Modify patch to catch those cases.
2021-08-04 09:49:48 -06:00
Greg Sjaardema
7b6f11c544
The coord dimids should be written for all variables
See discussion in #1279
2021-08-03 13:36:34 -06:00
Edward Hartnett
c77c4a9a40 fixing H5Linterate() API compatipility problem 2021-08-03 02:27:57 -06:00
Edward Hartnett
5d3e7a5147 fixed warning in tst_h_files4.c 2021-08-03 01:53:12 -06:00
Ward Fisher
84f0696e7d
Merge pull request #2036 from Unidata/gh1983.wif
Address optimization issue
2021-07-29 11:15:29 -06:00
Ward Fisher
0bc8c2e9c3
Merge pull request #2040 from mathstuf/replace-invalid-utf8
ncexhash: replace invalid UTF-8 sequence
2021-07-28 11:16:55 -06:00
Ben Boeckel
2472cda4f0 ncexhash: replace invalid UTF-8 sequence 2021-07-28 12:51:30 -04:00
Ward Fisher
a89e259431 Added -fno-strict-aliasing to CFLAGS when the compiler supports it and cmake is in use. 2021-07-27 11:22:48 -06:00
Ward Fisher
a8001f03e1 Added -fno-strict-aliasing to CFLAGS when the compiler supports it and autotools are in use. 2021-07-27 11:16:58 -06:00
Ward Fisher
2cfd0cb1fe
Merge pull request #2034 from ArchangeGabriel/patch-1
libhdf5/H5FDhttp: add missing semicolons to H5Epush_ret
2021-07-22 14:26:56 -07:00
Ward Fisher
9f798e2ed6 Merge branch 'virtual_datasets' of https://github.com/d70-t/netcdf-c into gh1983.wif 2021-07-19 09:44:35 -07:00
Ward Fisher
7840f89500 Merge remote-tracking branch 'origin/master' into gh1983.wif 2021-07-19 09:11:23 -07:00
Ward Fisher
24330edc80
Merge pull request #2032 from DennisHeimbigner/newformat.dmh
Move to Version 2 NCZarr Extended Meta-Data
2021-07-19 09:09:01 -07:00
Ward Fisher
01718d7877
Merge branch 'master' into newformat.dmh 2021-07-19 09:08:45 -07:00
Ward Fisher
847c12e716
Merge pull request #2035 from DennisHeimbigner/badchunkpath.dmh
Fix chunk key when using dimension_separator - high priority
2021-07-19 09:07:33 -07:00
Dennis Heimbigner
8cdf5943ac Update RELEASE_NOTES 2021-07-18 19:42:26 -06:00
Dennis Heimbigner
6b28409b54 Fix chunk key when using dimension_separator
The construction of the chunk key is malformed
when using dimension_separator rather than always
using '/'.

This is a priority bug.
2021-07-18 19:38:02 -06:00
Dennis Heimbigner
9417055c3e Fix bad chunkpath calculation 2021-07-18 16:20:22 -06:00
Bruno Pagani
74fe2fe95b
libhdf5/H5FDhttp: add missing semicolons to H5Epush_ret
In HDF5 1.12.1, this was changed from optional to required per the changelog:

>H5Epush_ret() is a function-like macro that has been changed to
>contain a `do {} while(0)` loop. Consequently, a trailing semicolon
>is now required to end the `while` statement. Previously, a trailing
>semi would work, but was not mandatory.

This should be backward compatible with older version of HDF5.
2021-07-18 20:12:47 +00:00
Dennis Heimbigner
669fd34357 remove push 2021-07-18 13:37:51 -06:00
Dennis Heimbigner
27ce37febf Merge branch 'newformat.dmh' of https://github.com/DennisHeimbigner/netcdf-c into newformat.dmh 2021-07-18 13:36:51 -06:00
Dennis Heimbigner
7f61f6b43c undebug 2021-07-18 13:36:39 -06:00
Dennis Heimbigner
fef6353d0e Bad file reference 2021-07-17 20:32:43 -06:00
Dennis Heimbigner
73a94362dd Update RELEASE_NOTES 2021-07-17 16:58:19 -06:00
Dennis Heimbigner
d953899559 Move to Version 2 NCZarr Extended Meta-Data
re: https://github.com/zarr-developers/zarr-specs/issues/41

After discussions with the Zarr community, it was decided to
convert to a new representation of the NCZarr meta-data extensions: version 2.
These extensions store information necessary to mapping the Zarr data model
to the netcdf-4 data model.

The basic change is to remove the NCZarr specific objects: .nczarr, .nczgroup, .nczarray, and .nczattr.
The contents of these objects is moved into the corresponding existing Zarr objects as special keys. The mapping is as follows:

* ''.nczarr'' => ''/.zgroup/_NCZARR_SUPERBLOCK_''
* ''.nczgroup => ''.zgroup/_NCZARR_GROUP_''
* ''.nczarray => ''.zarray/_NCZARR_ARRAY_''
* ''.nczattr => ''.zattr/_NCZARR_ATTR_''

Backward compatibility is maintained by looking for the object ''/.nczarr''
and if found, then assuming that the dataset is in the older version 1 format.
This compatibility only supports reading of such version 1 datasets.

Documentation and test cases are also added.

Misc. Other Changes:
1. The json parsing code was added to the general library instead of nczarr only (ncjson.c, ncjson.h).
2. Improved support for different platform paths by allowing conversion
   to a single common path representation.
3. Add some new error codes.
4. Modify nccopy usage to mention the new chunking specification.
2021-07-17 16:55:30 -06:00
Ward Fisher
4aeafe2d3a Fix an accidentally-introduced bug. 2021-07-13 12:07:56 -06:00
Ward Fisher
30621b38d3 Eliminate a lot of 'result of operation is undefined or garbage' errors reported by static analysis. These errors appeared to be false positives as there was logic that should prevent their occurance, but it's possible that optimization would result in these error states occuring. 2021-07-12 16:40:27 -06:00
Ward Fisher
0451296574 Added explicit initialization to address some potential issues raised by clang static analysis. 2021-07-09 13:48:35 -06:00
Ward Fisher
907e300e3e Merge remote-tracking branch 'origin/master' into gh1983.wif 2021-07-08 14:52:23 -06:00