mirror/netcdf-c
2
0
Fork 0
mirror of https://github.com/Unidata/netcdf-c.git synced 2024-12-27 08:49:16 +08:00
Code Issues Packages Projects Releases Wiki Activity
9,169 Commits 90 Branches 75 Tags 88 MiB
ea8d8dd05b
Commit Graph

9169 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Edward Hartnett
ea8d8dd05b documenting logging 2023-04-06 08:04:57 -06:00
Ward Fisher
43abd699e1
Merge pull request #2661 from WardF/hdf5-1.14.0-ci.wif 
Add hdf5 1.14.0 to GitHub CI.
 2023-03-14 13:57:52 -06:00
Ward Fisher
331ed2bdab Expand CI testing with HDF5 1.14.0 2023-03-14 11:47:57 -06:00
Ward Fisher
77738e546d Add hdf5 1.14.0 to GitHub CI. 2023-03-14 11:39:14 -06:00
Ward Fisher
97dbb4f25b
Merge pull request #2635 from DennisHeimbigner/vfd13.dmh 
Extend the dispatch table for H5FD back to version 1.13.2
 2023-03-14 11:36:17 -06:00
Ward Fisher
9c388dfd6a
Merge branch 'main' into vfd13.dmh 2023-03-14 11:36:09 -06:00
Ward Fisher
bb632f269d
Merge pull request #2630 from DennisHeimbigner/encode.dmh 
Enable ACCEPT_ENCODING on DAP requests
 2023-03-07 14:18:56 -07:00
Ward Fisher
8d51666d04
Merge branch 'main' into encode.dmh 2023-03-07 14:18:38 -07:00
Ward Fisher
59cca5c955
Merge pull request #2649 from DennisHeimbigner/byterange.dmh 
Fix byterange handling of some URLS
 2023-03-06 10:59:38 -07:00
Dennis Heimbigner
69e84fe9f1 Fix byterange handling of some URLS 
re: Issue

The byterange handling of the following URLS fails.

### Problem 1: "https://crudata.uea.ac.uk/cru/data/temperature/HadCRUT.4.6.0.0.median.nc#mode=bytes"
It turns out that byterange in hdf5 has two possible targets: S3 and not-S3 (e.g. a thredds server or the crudata URL above). Each uses a different HDF5 Virtual File Driver (VFD).
I incorrectly set up the byterange code in libhdf5 so that it would choose one or the other of the two VFD's for any netcdf-c library build. The fix is to allow it to choose either one at run-time.

### Problem 2: "https://noaa-goes16.s3.amazonaws.com/ABI-L1b-RadF/2022/001/18/OR_ABI-L1b-RadF-M6C01_G16_s20220011800205_e20220011809513_c20220011809562.nc#mode=bytes,s3"
When given what appears to be an S3-related URL, the netcdf-c library code converts it into a canonical, so-called "path" format. In casing out the possible input URL formats, I missed the case where the host contains the bucket ("noaa-goes16"), but not the region. So the fix was to check for this case.

## Misc. Related Changes
1. Since S3 is used in more than just NCZarr, I changed the automake/cmake options to replace "--enable-nczarr-s3" with "--enable-s3", but keeping the former option as a synonym for the latter. This also entailed cleaning up libnetcdf.settings WRT S3 support
2. Added the above URLS as additional test cases

## Misc. Un-Related Changes
1. CURLOPT_PUT is deprecated in favor to CURLOPT_UPLOAD
2. Fix some minor warnings

## Open Problems
* Under Ubuntu, either libcrypto or aws-sdk-cpp has a memory leak.
 2023-03-02 19:51:02 -07:00
Ward Fisher
a715d1a12b
Merge pull request #2607 from gsjaardema/patch-56 
Missing `goto fail`
 2023-03-02 16:55:22 -07:00
Ward Fisher
00a722b253
Merge pull request #2618 from skosukhin/fix-macro-use 
Fix macro usage
 2023-02-27 18:39:20 -07:00
Ward Fisher
05b82feec0
Merge pull request #2641 from WardF/minor_cleanup.wif 
Cleaning up a few stray issues
 2023-02-27 16:49:50 -07:00
Ward Fisher
b40f8ce367 Invert solution as discussed at https://github.com/Unidata/netcdf-c/pull/2618 2023-02-27 16:07:36 -07:00
Ward Fisher
6eb435aca4
Merge pull request #2623 from magnusuMET/bugfix/netcdf_v4.9.1 
Fix dest for non-m4 path
 2023-02-27 15:52:34 -07:00
Ward Fisher
96c41b1de6
Merge pull request #2592 from mwestphal/improve_nczarr_zip_logic 
Avoid optionaly depends on zip for NCZarr
 2023-02-27 15:50:49 -07:00
Ward Fisher
0ff269a4e0 Correct a potential null pointer dereference. 2023-02-27 15:48:57 -07:00
Ward Fisher
267b26f123 Fix a logic error that was resulting in an easy-to-miss error when running configure. 2023-02-27 15:12:32 -07:00
Ward Fisher
677587b444 Fix issue with dangling test file not getting cleaned up. 2023-02-27 15:07:33 -07:00
Ward Fisher
a1d5e98896 Turn nczarr zip support off by default in cmake, add a status line indicating whether nczarr-zip-support is available, in libnetcdf.settings. 2023-02-27 13:34:26 -07:00
Ward Fisher
1e2abd11a5 Update the version of the cache action used by github action from v2 to v3. 2023-02-27 13:15:00 -07:00
Ward Fisher
17b4cb394c
Merge pull request #2633 from WardF/gh1983.wif 
A small, but meaningful start, to addressing undefined behavior
 2023-02-24 15:14:00 -07:00
Ward Fisher
1d908e29ac Explicit cast to unsigned char. 2023-02-24 13:37:28 -07:00
Ward Fisher
0c45c39607 More issues returned by sanitizer, related to attempts to assign MAX_UNSIGNED_CHAR (255) to a variable of type char. 2023-02-24 11:48:00 -07:00
Ward Fisher
b7635f061f Fixed an issue where memcpy was potentially passed a null pointer. 2023-02-24 11:27:36 -07:00
Dennis Heimbigner
6a4ab61fc8 Missed one occurrence of 1,14,0 2023-02-22 15:30:26 -07:00
Dennis Heimbigner
21b920cbab update RELEASENOTES 2023-02-22 12:30:15 -07:00
Dennis Heimbigner
8556a9d634 Extend the dispatch table for H5FD back to version 1.13.2 
re: Issue https://github.com/Unidata/netcdf-c/issues/2634
re: PR https://github.com/Unidata/netcdf-c/pull/2615
re: Issue https://github.com/Unidata/netcdf-c/issues/2614

It turns out that the H5FD table change identified in
issue https://github.com/Unidata/netcdf-c/issues/2614
actually occurred in HDF5 version 1.13.2.
Since we do not test with 1.13.x, we did not catch this.
 2023-02-22 11:15:43 -07:00
Ward Fisher
7762823483 Correct another uninitialized issue. 2023-02-21 16:58:28 -07:00
Ward Fisher
df7f6ec571 Correct undefined variable error. 2023-02-21 16:54:51 -07:00
Ward Fisher
5ae3655436 Fixing issues uncovered by compiling with '-fsanitize=undefined' and running nc_test/nc_test, in support of https://github.com/Unidata/netcdf-c/issues/1983, amongst others. The cast as was being used was undefined behavior, and had to be worked around in a style approximating C++'s 'reinterpret_cast' 2023-02-21 15:02:14 -07:00
Ward Fisher
0034e31e58
Merge pull request #2631 from DennisHeimbigner/distcheck.dmh 
Fix a distcheck failure with nczarr_test/run_interop.sh
 2023-02-17 16:31:19 -07:00
Ward Fisher
6a8d5b9314 Remove a stray character at the head file. 2023-02-17 15:58:44 -07:00
Dennis Heimbigner
295c132789 Fix a distcheck failure with nczarr_test/run_interop.sh 
The problem was that files were being copied
into the ${srcdir} rather than ${builddir} directory.
 2023-02-17 13:01:11 -07:00
Ward Fisher
bb81ab332f
Merge pull request #2628 from WardF/gh2627.wif 
Unit Testing, Performance Testing infrastructure options.
 2023-02-17 09:44:52 -07:00
Dennis Heimbigner
e9bf385d3f Update Release notes 2023-02-16 20:24:13 -07:00
Dennis Heimbigner
e31ce10842 Enable ACCEPT_ENCODING on DAP requests 
re: PR https://github.com/Unidata/netcdf-c/issues/2622

H/T Nathan Potter for finding this.

Apparently the existing library DAP code for supporting
compressed http responses was disabled.

So:
1. enable CURLOPT_ACCEPT_ENCODING by default
2. Add a new HTTP.ENCODE for .dodsrc to allow it to be disabled.
 2023-02-16 20:21:22 -07:00
Ward Fisher
49c71a53b4 Turn benchmarks off by default. They require netcdf4, additional logic is required in order to have them on by default. 2023-02-16 16:41:19 -07:00
Ward Fisher
efa0c8df45 Add execute bit to test scripts 2023-02-16 15:58:42 -07:00
Ward Fisher
1931a487d2 Fix missing endif statement 2023-02-16 15:56:25 -07:00
Ward Fisher
d6a5f987c1 Add generated parallel tests for nc_perf, cmake-based build system. 2023-02-16 15:52:43 -07:00
Ward Fisher
cd655eb442 Correct typo in CMakeLists.txt 2023-02-16 15:09:14 -07:00
Ward Fisher
2efb340488 Wiring performance benchmarks into cmake, cleaned up serial compression performance test dependency on MPI. 2023-02-16 15:06:27 -07:00
Ward Fisher
c05505a1b8 Added benchmarking option to cmake-based builds, turned on unit-testing by default 2023-02-16 11:20:45 -07:00
Ward Fisher
678f632d95
Merge pull request #2619 from WardF/gh2274.wif 
Update nc-config
 2023-02-16 10:27:59 -07:00
Ward Fisher
23ba09e5a5
Merge branch 'main' into gh2274.wif 2023-02-16 10:27:50 -07:00
Magnus Ulimoen
c85c804279 Fix setting dest for non-m4 path 2023-02-15 11:43:14 +01:00
Ward Fisher
d02a9a21e7
Merge pull request #2615 from DennisHeimbigner/fixh5fdhttp.dmh 
Modify H5FDhttp.c to work with HDF5 1.14.0
 2023-02-13 10:54:28 -07:00
Ward Fisher
6f55c85260 Update nc-config in support of https://github.com/Unidata/netcdf-c/issues/2274 2023-02-13 10:52:41 -07:00
Sergey Kosukhin
f40f524303 Fix macro usage 2023-02-13 16:57:06 +01:00