Commit Graph

1785 Commits

Author SHA1 Message Date
dmh
d7de6fd551 [NCF-287/MCI-552767
Problem related to NCF-284.
Namely an old thredds server that
does not properly implement the
dap2 spec. It is accessing a field of a grid
but is not wrapping it as a structure.
url:http://thredds.aodn.org.au/thredds/dodsC/IMOS/ACORN/gridded_1h-avg-current-map_QC/SAG/2010/01/27/IMOS_ACORN_V_20100127T023000Z_SAG_FV01_1-hour-avg.nc.dds?SPEED.SPEED

In any case, this exposed another bug.
Also, in looking at this, I realized that the
code could be simplified.
2014-02-05 17:05:33 -07:00
Ward Fisher
e66ab99303 Updated documentation in preparation for upcoming 4.3.1.1 bugfix release. 2014-02-05 10:16:10 -07:00
Ward Fisher
f3be082363 Updated RELEASE_NOTES.md with reference to Jira ticket for DAP/Cygwin64-related bugfix. 2014-02-04 16:41:15 -07:00
Ward Fisher
feeeb70c31 Updated developer doxyfile to automatically parse the '.doc' and '.md' files present in man4. 2014-02-04 16:36:44 -07:00
dmh
56758efde9 Merge branch 'master' of http://github.com/Unidata/netcdf-c 2014-02-04 16:27:13 -07:00
dmh
0f4b72c53b [NCF-286]/e-support:JVN-123940
using cygwin64 causes a couple of bugs during make check.
Fixes are as follows:
1. in ncdump.c and nccopy.c change all occurrences of
   'return EXIT_FAILURE'
   and
   'return EXIT_SUCCESS'
   with
   exit(EXIT_FAILURE)
   and
   exit(EXIT_SUCCESS)
   respectively.
   I have no idea why this works.
2. in libdap2/ncdap3a.c#freeNCDAPCOMMON,
   remove the call to nc_abort, it is
   causing a loop; not sure why this
   is not caught under other operating systems.
2014-02-04 16:26:52 -07:00
Ward Fisher
7debd132d2 Bumped version to 4.3.1.1 in preparation for upcoming bugfix release.
Modified the Doxyfile templates to use 'dot', when available, to generate class diagrams instead of the inferior diagram engine bundled in doxygen.
2014-02-04 16:13:18 -07:00
Ward Fisher
7786b78cfc Reorganized Windows includes. 2014-02-04 11:10:27 -07:00
Ward Fisher
c1407c3239 Removed stray debugging message. 2014-02-03 14:42:56 -07:00
Ward Fisher
de05ed9c11 Added a note to RELEASE_NOTES.md regarding the upcoming bug fix release. 2014-01-29 16:11:24 -07:00
dmh
893ab1c3fe [NCF-284]/ ZQX-155900
Some servers do not properly
implement the current DAP2 spec.
It turns out that this server is one of those:
    http://nomads.ncep.noaa.gov:9090/
When a reference such as this is made:
    http://nomads.ncep.noaa.gov:9090/dods/gens/gens20140123/gep_all_12z?prmslmsl[0][0][0][0:359]
tt is returning this:
Dataset {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
} gens%2fgens20140123%2fgep_all_12z;

when it should be returning this:
Dataset {
  Structure {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
  } prmslmsl;
} gens%2fgens20140123%2fgep_all_12z;

The reason is that when picking fields out of a grid,
one must maintain the fully qualified name, so the grid
is converted to an enclosing structure.

It turns out that the problem was that
when I create the new structure node, I was
improperly linking it into the existing graph.
This caused a null pointer failure.
Fix is to make sure the relevant field (node->root)
is set.
2014-01-24 13:35:10 -07:00
dmh
8541a32175 [NCF-284]/ ZQX-155900
Some servers do not properly
implement the current DAP2 spec.
It turns out that this server is one of those:
    http://nomads.ncep.noaa.gov:9090/
When a reference such as this is made:
    http://nomads.ncep.noaa.gov:9090/dods/gens/gens20140123/gep_all_12z?prmslmsl[0][0][0][0:359]
tt is returning this:
Dataset {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
} gens%2fgens20140123%2fgep_all_12z;

when it should be returning this:
Dataset {
  Structure {
    float prmslmsl[ens=1][time=1][lat=1][lon=360];
  } prmslmsl;
} gens%2fgens20140123%2fgep_all_12z;

The reason is that when picking fields out of a grid,
one must maintain the fully qualified name, so the grid
is converted to an enclosing structure.

It turns out that the problem was that
when I create the new structure node, I was
improperly linking it into the existing graph.
This caused a null pointer failure.
Fix is to make sure the relevant field (node->root)
is set.
2014-01-24 13:26:00 -07:00
Ward Fisher
7b743d68ad An issue turned out to be related to gcov symbols inserted at link time by the gcov libraries. Removing mcmodel argument. 2014-01-24 12:25:27 -07:00
Ward Fisher
6c1d499e87 Move option definition in CMakeLists.txt 2014-01-24 11:15:17 -07:00
Ward Fisher
3d681fa183 Reformatted CMakeLists.txt to move compiler options into a single unified block at the top. 2014-01-24 11:10:41 -07:00
Ward Fisher
dedeffc822 Removed stray character. 2014-01-24 10:31:37 -07:00
Ward Fisher
8ef7441a5e Added new variable, 'ENABLE_UNUSED_VAR_PAR_WARNINGS' to make debug output more or less verbose. It is off by default. 2014-01-24 10:30:14 -07:00
dmh
133b17810d Remove the 64-bit-offset test for pnetcdf; apparently if can handle it ok 2014-01-23 10:58:25 -07:00
Ward Fisher
9fa9e6a88f Having problems finding a syntax that works for both OSX and Linux, added a platform check instead. Perhaps this will work. 2014-01-22 10:41:59 -07:00
Ward Fisher
37a329f97e Updated comparison to work on Linux as well as OSX. 2014-01-22 10:19:47 -07:00
Ward Fisher
90de6044cc Updated comparison to work on Linux as well as OSX. 2014-01-22 09:53:26 -07:00
Ward Fisher
a708984b69 OSX ‘expr’ is built on BSD expr, which does not contain the ‘index’ directive. This work around allows this test to work on OSX and linux. 2014-01-22 09:45:54 -07:00
Ward Fisher
0c140de870 Turned off debug messages in ocdebug.h. 2014-01-21 15:40:34 -07:00
dmh
75adeae78b add some debug info about packet contents 2014-01-21 13:04:52 -07:00
dmh
0fa9dc98eb synch oc 2014-01-21 12:50:15 -07:00
dmh
dfc3749506 [NCF-282]/ HAD-595112
The code that tests if a path is a url is
faulting when the url does not end in a slash
(e.g. http://thredds-tests.ucar.edu).
The code that tests if a path is a url is
faulting when the url does not end in a slash
(e.g. http://thredds-tests.ucar.edu).
CF-273]/HZY-708311

Solution was to do a null pointer test.
Added a test (tst_misc).
2014-01-20 16:11:45 -07:00
dmh
6a6891b72b fixed testing of constrained test for ncdap 2014-01-19 13:01:50 -07:00
Ward Fisher
ae8e5d1ff2 Updated windows binary download links. 2014-01-16 14:24:44 -07:00
Ward Fisher
49d3addcaa Updated release notes. 2014-01-16 14:21:43 -07:00
Ward Fisher
63ac4cf10e Updated version in preparation for 4.3.1 release. 2014-01-16 13:44:12 -07:00
Ward Fisher
0032af978b Added INQ_FORMAT_EXTENDED-related tests to the cmake build system (based on inclusion in autotools-based builds). 2014-01-16 13:14:49 -07:00
Ward Fisher
2957645985 Addressed a coverity issue of minor importance. 2014-01-15 12:48:21 -07:00
Ward Fisher
ccef11467a Corrected a typo re: current version. 2013-12-24 14:57:04 -07:00
dmh
582410a407 [NCF-273]/HZY-708311
Add a new function called nc_inq_format_extended that
returns more detailed format information (vis-a-vis
nc_inq_format) about an open dataset.

Note that the netcdf API will present the file as if it had
the format specified by nc_inq_format.  The true file
format, however, may not even be a netcdf file; it might be
DAP, HDF4, or PNETCDF, for example. This function returns
that true file type.  It also returns the effective mode for
the file.

signature: nc_inq_format_extended(int ncid, int* formatp, int* modep)
where
* ncid is the NetCDF ID from a previous call to nc_open() or
  nc_create().
* formatp is a pointer to a location for returned true format.
* modep is a pointer to a location for returned mode flags.

Refer to the actual list in the file netcdf.h to see the
currently defined set.

Also added test cases (tst_formatx*).
2013-12-22 12:53:20 -07:00
dmh
965150f4f0 null fix 2013-12-20 14:01:44 -07:00
dmh
588156cfbc fix typo 2013-12-20 13:59:40 -07:00
Ward Fisher
d46a18c2bb Bumped revision in configure.ac, CMakelists.txt. 2013-12-19 14:38:07 -07:00
Ward Fisher
a048bb54e7 Updated links on Windows download document to reflect new file names. 2013-12-19 10:23:51 -07:00
Ward Fisher
5b547e7689 Updated Release Notes. 2013-12-19 10:22:54 -07:00
Ward Fisher
9f40e2cee2 Updated RELEASE NOTES, bumped revision to rc6 in preparation for forthcoming release candidate. 2013-12-19 10:21:34 -07:00
dmh
8fbb4a68d5 Merge branch 'master' of https://github.com/Unidata/netcdf-c
Rebasing
2013-12-19 09:36:05 -07:00
Ward Fisher
b3388178b4 Corrected a double-free issue reported by Coverity. 2013-12-17 15:54:14 -07:00
Ward Fisher
acd3565140 Replaced a comparison of floating point variables to a difference/epsiolon test. 2013-12-17 14:30:14 -07:00
Russ Rew
a98cdc647f Added entry for fix. 2013-12-17 13:38:38 -07:00
Ward Fisher
f5ec4ba7a0 Removed reference to old test file. 2013-12-16 15:22:59 -07:00
Quincey Koziol
0d42ac7e87 Switch test for nc_inq_unlimdim and nc_inq_unlimdims to use the same ordering as
the rest of the dimension queries.  Correct error in library where types used
in sub-group variables but that were added to the file after the sub-group was
created weren't available for sub-group variables to use.  Start cleaning up
test suite and un-commenting tests that were commented out (got up to
nc_test4/tst_fills2.c, alphabetically) before running into an error in HDF5.
2013-12-15 19:55:41 -06:00
Quincey Koziol
11e6343ae1 Correct order of unlimited dim checking in test. (Was relying on old behavior
of backwards ordering)
2013-12-14 10:08:01 -06:00
Quincey Koziol
bc989e7c34 Merge remote-tracking branch 'upstream/master' 2013-12-10 21:07:23 -06:00
Ward Fisher
b43955ab49 Added test contributed by Jeff Whitaker. 2013-12-10 15:50:20 -07:00
dmh
564a9d56a4 Merge branch 'master' of https://github.com/Unidata/netcdf-c 2013-12-10 11:23:10 -07:00