Commit Graph

147 Commits

Author SHA1 Message Date
Ward Fisher
16115303a5 Missing pipe character. 2022-01-24 16:15:57 -07:00
Ward Fisher
05e207f5ca Syntax error. 2022-01-24 16:12:11 -07:00
Ward Fisher
acbbde16a1 Syntax error. 2022-01-24 16:10:51 -07:00
Ward Fisher
db98c57af6 HDF5 configuration diagnostic output 2022-01-24 16:09:39 -07:00
Ward Fisher
472e4c8b36 Oh right, Unix Makefiles 2022-01-24 16:02:45 -07:00
Ward Fisher
3058b760ad Force CMake to use gcc 2022-01-24 15:59:10 -07:00
Ward Fisher
7e1c770dff Adding hdf5 info for cmake-based tests. 2022-01-24 15:55:13 -07:00
Ward Fisher
f12eb2d0f9 Moving on to cmake-based github actions. 2022-01-24 15:47:27 -07:00
Dennis Heimbigner
446348ed18 Add complete bitgroom support to NCZarr
re: PR https://github.com/Unidata/netcdf-c/pull/2088
re: PR https://github.com/Unidata/netcdf-c/pull/2130
replaces: https://github.com/Unidata/netcdf-c/pull/2140

Changes:
* Add NCZarr-specific quantize functions to the dispatch table.
* Copy (modified) quantize code from libhdf5 to NCZarr
* Add quantize invocation to zvar.c
* Add support for _QuantizeBitgroomNumberOfSignificantDigits
and _QuantizeGranularBitgroomNumberOfSignificantDigits to ncgen.
* Modify nc_test4/tst_quantize.c to allow it to be used both for hdf5
  and for nczarr.
* Make dap4 properly handle quantize functions in dispatch table.
* Add quantize attribute support to ncgen.

Other changes:
* Caught and fixed some S3 problems
* Fixed some nczarr fillvalue problems.
* Fixed some nczarr cache problems.
* Cleanup some flaws in libdispatch/dinfermodel.c
* Allow byterange requests to S3 be readable by dinfermodel.c/check_file_type
* Remove the libnczarr ztracedispatch code (big change).
2022-01-24 15:22:24 -07:00
Ward Fisher
27db0f2354 More tweaks. 2022-01-24 15:21:29 -07:00
Ward Fisher
3c017da5e3 Collapse build and run test steps into a single step, no need to build all the tests before seeing if any fail. 2022-01-24 15:11:58 -07:00
Ward Fisher
3898d4f80a Remove stray text. 2022-01-24 13:18:05 -07:00
Ward Fisher
84070ad177 Next iteration of compilation test. 2022-01-24 13:08:55 -07:00
Ward Fisher
08598a761f Additional compilation work. 2022-01-24 12:20:04 -07:00
Ward Fisher
e8e3141cb1 Really simplify things. 2022-01-24 11:45:46 -07:00
Ward Fisher
0333da7be5 Clean up some Unix-related cruft. 2022-01-24 11:38:21 -07:00
Ward Fisher
ddd675a6d7 Temporarily disable cache 2022-01-24 11:30:14 -07:00
Ward Fisher
d0ad57fb3e Further developments unfolding. 2022-01-24 11:24:45 -07:00
Ward Fisher
d76fbe3fc2 Remove stray text. 2022-01-24 11:06:21 -07:00
Ward Fisher
3a12cee940 Working on MinGW/MSYS2 support. Attempting workflow with system-installed libhdf5 2022-01-24 11:05:33 -07:00
Ward Fisher
a6e7ad17a2 Added cmake to the mingw-based test. 2022-01-24 10:54:00 -07:00
Ward Fisher
4ad9f00493 Add skeleton mingw/msys2 Github CI tests. 2022-01-24 10:51:19 -07:00
Ward Fisher
5f3de855e5
Merge pull request #2194 from WardF/update-hdf5-github-actions.wif
Collapse and update the HDF5 versions being tested on Github Actions.
2022-01-21 10:34:06 -07:00
Ward Fisher
6d5305afd6 Collapse and update the HDF5 versions being tested on Github Actions. 2022-01-21 09:10:45 -07:00
Ward Fisher
2570ac1849 Avoid name collision in macOS tests. 2022-01-21 09:01:40 -07:00
Ward Fisher
c7dc1c25a1 Removed OSX tests from run-on-push, modify so that they run on pull request. 2022-01-20 17:11:22 -07:00
Ward Fisher
286abab31f Refactor triggers on GA runs. 2022-01-20 16:55:18 -07:00
Ward Fisher
2d39cc297e Add a missing space. 2022-01-20 16:53:06 -07:00
Ward Fisher
bbf1433c30 Remove HDF4 2022-01-20 16:38:29 -07:00
Ward Fisher
7a6accad44 More work on the OSX github actions. 2022-01-20 16:25:52 -07:00
Ward Fisher
c01f4adf8e Additional expansion of naming. 2022-01-20 16:13:38 -07:00
Ward Fisher
9a03ef6f20 Cache automake install. 2022-01-20 16:11:32 -07:00
Ward Fisher
0fb73f8545 Move autoconf installation stanza 2022-01-20 16:01:07 -07:00
Ward Fisher
4fdb855a20 More scripting. 2022-01-20 15:57:32 -07:00
Ward Fisher
36edd4ce96 Installing autoconf tools 2022-01-20 15:53:29 -07:00
Ward Fisher
532156f188 Remove more calls to apt. 2022-01-20 15:49:34 -07:00
Ward Fisher
e5c68d087e Removed call to autoreconf 2022-01-20 15:15:49 -07:00
Ward Fisher
7059f28719 Syntax error discovered (I hope) 2022-01-20 15:14:28 -07:00
Ward Fisher
3020729638 Remove ubuntu-specific thing. 2022-01-20 15:05:14 -07:00
Ward Fisher
815483b5b8 Sorting out the reported syntax error. 2022-01-20 15:04:01 -07:00
Ward Fisher
c0f0c7a6a4 More testing. 2022-01-20 15:01:51 -07:00
Ward Fisher
10cc5038d3 Temporarily disable ubuntu tests on PR. 2022-01-20 14:58:38 -07:00
Ward Fisher
65e5fd857c Temporarily disable ubuntu tests on PR. 2022-01-20 14:57:02 -07:00
Ward Fisher
d951322351 Renaming jobs to differentiate between Ubuntu and Linux jobs. 2022-01-20 14:49:50 -07:00
Ward Fisher
4d167366be It was worth a shot. 2022-01-20 14:45:16 -07:00
Ward Fisher
686f51eaac Syntax 2022-01-20 14:43:44 -07:00
Ward Fisher
bb17007350 Syntax 2022-01-20 14:42:55 -07:00
Ward Fisher
a9d792c1af Collapse some redundant definitions in the Ubuntu-based workflow. 2022-01-20 14:41:11 -07:00
Ward Fisher
932a60c005 Renamed some of the job steps. 2022-01-20 14:38:10 -07:00
Ward Fisher
070b8609ee Adding github actions. 2022-01-20 14:27:47 -07:00
Ward Fisher
8d4e0f8362 Renamed the workflow file for running ubuntu-based tests. 2022-01-20 14:12:17 -07:00
Dennis Heimbigner
9380790ea8 Support MSYS2/Mingw platform
re:

The current netcdf-c release has some problems with the mingw platform
on windows. Mostly they are path issues.

Changes to support mingw+msys2:
-------------------------------
* Enable option of looking into the windows registry to find
  the mingw root path. In aid of proper path handling.
* Add mingw+msys as a specific platform in configure.ac and move testing
  of the platform to the front so it is available early.
* Handle mingw X libncpoco (dynamic loader) properly even though
  mingw does not yet support it.
* Handle mingw X plugins properly even though mingw does not yet support it.
* Alias pwd='pwd -W' to better handle paths in shell scripts.
* Plus a number of other minor compile irritations.
* Disallow the use of multiple nc_open's on the same file for windows
  (and mingw) because windows does not seem to handle these properly.
  Not sure why we did not catch this earlier.
* Add mountpoint info to dpathmgr.c to help support mingw.
* Cleanup dpathmgr conversions.

Known problems:
---------------
* I have not been able to get shared libraries to work, so
  plugins/filters must be disabled.
* There is some kind of problem with libcurl that I have not solved,
  so all uses of libcurl (currently DAP+Byterange) must be disabled.

Misc. other fixes:
------------------
* Cleanup the relationship between ENABLE_PLUGINS and various other flags
  in CMakeLists.txt and configure.ac.
* Re-arrange the TESTDIRS order in Makefile.am.
* Add pseudo-breakpoint to nclog.[ch] for debugging.
* Improve the documentation of the path manager code in ncpathmgr.h
* Add better support for relative paths in dpathmgr.c
* Default the mode args to NCfopen to include "b" (binary) for windows.
* Add optional debugging output in various places.
* Make sure that everything builds with plugins disabled.
* Fix numerous (s)printf inconsistencies betweenb the format spec
  and the arguments.
2021-12-23 22:18:56 -07:00
Dennis Heimbigner
73caeb674d Cleanup the CMake inter-test dependencies
The ncdump test set has a number of inter-test dependencies
that are not properly established in ncdump/CMakeLists.txt.

So this PR attempts to:
1. reorder the tests
2. change tests in CMakeLists.txt from build_bin_test_no_prefix to add_bin_test_no_prefix so they get executed

Plus a couple of minor bug fixes.
1. Change ENABLE_NC4 => ENABLE_HDF5 in github action.
2. fix a memory error in findtestserver.c.in
3. fix bug in ncdap_tests/tst_urls.sh
4. fix netcdf file name bug in tst_netcdf4_4.sh
2021-12-20 15:13:08 -07:00
Dennis Heimbigner
11fe00ea05 Add filter support to NCZarr
Filter support has three goals:

1. Use the existing HDF5 filter implementations,
2. Allow filter metadata to be stored in the NumCodecs metadata format used by Zarr,
3. Allow filters to be used even when HDF5 is disabled

Detailed usage directions are define in docs/filters.md.

For now, the existing filter API is left in place. So filters
are defined using ''nc_def_var_filter'' using the HDF5 style
where the id and parameters are unsigned integers.

This is a big change since filters affect many parts of the code.

In the following, the terms "compressor" and "filter" and "codec" are generally
used synonomously.

### Filter-Related Changes:
* In order to support dynamic loading of shared filter libraries, a new library was added in the libncpoco directory; it helps to isolate dynamic loading across multiple platforms.
* Provide a json parsing library for use by plugins; this is created by merging libdispatch/ncjson.c with include/ncjson.h.
* Add a new _Codecs attribute to allow clients to see what codecs are being used; let ncdump -s print it out.
* Provide special headers to help support compilation of HDF5 filters when HDF5 is not enabled: netcdf_filter_hdf5_build.h and netcdf_filter_build.h.
* Add a number of new test to test the new nczarr filters.
* Let ncgen parse _Codecs attribute, although it is ignored.

### Plugin directory changes:
* Add support for the Blosc compressor; this is essential because it is the most common compressor used in Zarr datasets. This also necessitated adding a CMake FindBlosc.cmake file
* Add NCZarr support for the big-four filters provided by HDF5: shuffle, fletcher32, deflate (zlib), and szip
* Add a Codec defaulter (see docs/filters.md) for the big four filters.
* Make plugins work with windows by properly adding __declspec declaration.

### Misc. Non-Filter Changes
* Replace most uses of USE_NETCDF4 (deprecated) with USE_HDF5.
* Improve support for caching
* More fixes for path conversion code
* Fix misc. memory leaks
* Add new utility -- ncdump/ncpathcvt -- that does more or less the same thing as cygpath.
* Add a number of new test to test the non-filter fixes.
* Update the parsers
* Convert most instances of '#ifdef _MSC_VER' to '#ifdef _WIN32'
2021-09-02 17:04:26 -06:00
Ward Fisher
18086dae10 Correct a typo in the github actions yaml file. 2021-08-25 14:32:01 -06:00
Ward Fisher
7ee0281c74 Test dependency on one-offs updated. 2021-08-25 14:31:09 -06:00
Ward Fisher
48d943864d Syntax debugging. 2021-08-25 14:28:59 -06:00
Ward Fisher
d6f06bf3d6 A bit more twiddling of the github actions workflow. 2021-08-25 14:25:41 -06:00
Ward Fisher
8fc52da9d7 Thanks to newer ctest functionality, if ctest tests fail, re-run just the failed ones with more verbose output. 2021-08-25 12:43:04 -06:00
Ward Fisher
40c3fc2169 Reverse GA workflow. Run the one-off tests first and then run the full test matrix. This should shorten the test/failure cycle. 2021-08-25 11:16:47 -06:00
Ward Fisher
912fd7574c Modify GA workflow a bit. 2021-08-24 15:22:20 -06:00
Ward Fisher
5bcf91f880 Correct spacing issue in GA yaml file. 2021-08-24 15:07:10 -06:00
Ward Fisher
37d6cc9191 Propagate github actions tests into cmake-based stanza. 2021-08-24 14:40:13 -06:00
Ward Fisher
1376067870 Added a one-off stanza for autoconf-based tests on Github Actions. 2021-08-24 14:26:28 -06:00
Edward Hartnett
e8d3198a77 added commas 2021-08-20 05:46:22 -06:00
Edward Hartnett
5c23e72e28 added 1.12.1 to hdf5 versions built by GitHub actions 2021-08-20 05:44:43 -06:00
Dennis Heimbigner
669fd34357 remove push 2021-07-18 13:37:51 -06:00
Ward Fisher
e21ef7bcb0
Merge branch 'master' into dap4fixes2.dmh 2021-06-01 14:11:39 -06:00
Ward Fisher
5b49ee9f3b Temporarily remove distcheck from Github Actions 2021-05-26 13:55:59 -06:00
Ward Fisher
6eaf39f3c3 Revert previous change. 2021-05-26 13:54:40 -06:00
Ward Fisher
a5d7277092 Testing a different theory 2021-05-26 13:44:56 -06:00
Ward Fisher
5f95b7ca9f Temporarily add an ssh-interface when make distcheck fails. 2021-05-26 13:15:12 -06:00
Ward Fisher
ceb9b29e17 Speculating on fix, perhaps a race issue on make distcheck when passed the command to use concurrent processes. 2021-05-26 11:16:22 -06:00
Ward Fisher
e2eb7bb52e Added DISTCHECK_CONFIGURE_FLAGS to Github Actions distcheck stanza. 2021-05-26 10:44:07 -06:00
Ward Fisher
d003f98367 Updated github actions to add make distcheck 2021-05-25 10:55:14 -06:00
Dennis Heimbigner
8ceafa62d4 Improve operation of the DAP4 code and fix bugs
re: e-support EOT-483791

* Add a new set of remote tests based on using the thredds-test server.
* Improve error reporting when server requests fail.
* Fix handing of _NCProperties attribute
2021-05-21 20:46:56 -06:00
Ward Fisher
95719addd2 Added 1.0.1 to test matrix in support of https://github.com/Unidata/netcdf-c/pull/1931#issuecomment-804312933 2021-03-26 14:50:22 -06:00
Dennis Heimbigner
911d0a5deb Enable nczarr testing in github actions.
Changes:
1. add "use_nczarr: [ nczarr_off, nczarr_on ]" to matrix
2. add libzip-dev to the apt installs (might need caching).
3. convert deprecated "--enable-netcdf-4" to "--enable-hdf5" (also for cmake)
2021-01-27 11:30:48 -07:00
Ward Fisher
bb2b864674 Added more updates 2020-12-16 09:34:42 -07:00
Ward Fisher
3e01272cee Added an apt update stanza to the github action script. 2020-12-16 09:19:21 -07:00
Ward Fisher
5fed325180 Cleaned up orphaned github action files, modified GA to run on PR instead of push. 2020-12-07 11:16:04 -07:00
Ward Fisher
4cf290dc0b
Merge pull request #1897 from DennisHeimbigner/oceanunavail.dmh
Disable use of opendap2.oceanbrowser.net
2020-12-04 16:11:47 -07:00
Ward Fisher
7fce4b3482 Clean up, bring over a new action script. This one uses apt and cached builds instead of conda. 2020-12-04 15:38:13 -07:00
Ward Fisher
1814da1f7f Temporarily reducing test matrix. 2020-12-03 12:20:52 -07:00
Ward Fisher
04640abe32 Github Action debugging. 2020-12-03 12:12:07 -07:00
Ward Fisher
9b9ca97712 Explicitly link rt library for github actions. 2020-12-03 12:09:24 -07:00
Ward Fisher
d263a48637 Correct previous 'fix' that wasn't. 2020-12-03 12:03:34 -07:00
Ward Fisher
f48ccb465d Address link issue on github actions platform. 2020-12-03 11:59:25 -07:00
Dennis Heimbigner
c797eb29ad remove worflows and fix ifdef 2020-12-02 16:36:09 -07:00
Dennis Heimbigner
af89295852 ignore 2020-12-01 22:09:13 -07:00
Dennis Heimbigner
5b8842b373
manual.yml 2020-12-01 22:06:16 -07:00
Dennis Heimbigner
62036cbf45
ignore.yml 2020-12-01 22:01:44 -07:00
Dennis Heimbigner
8cf8c31df4
automake-dmh.yml 2020-12-01 21:59:52 -07:00
Dennis Heimbigner
c164650cb6 rename 2020-12-01 21:58:10 -07:00
Dennis Heimbigner
6cdddd7596 update workflows 2020-12-01 21:53:33 -07:00
Dennis Heimbigner
0aa80f91d6 manual workflow 2020-12-01 21:48:39 -07:00
Ward Fisher
1ba45b9e9a Adding github actions to netcdf-c for CI purposes. 2020-11-30 11:21:51 -07:00